WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 5 months ago

Last modified 4 months ago

#26608 closed defect (bug) (fixed)

/wp-admin/includes/post.php: Make HTML tag standard compliant

Reported by: Latz Owned by:
Milestone: 4.2 Priority: lowest
Severity: trivial Version: 3.6
Component: Posts, Post Types Keywords: has-patch 3.9-early
Focuses: administration Cc:

Description

<br> tag isn't closed.

Attachments (1)

26608.diff (695 bytes) - added by Latz 18 months ago.

Download all attachments as: .zip

Change History (10)

@Latz18 months ago

comment:1 @Latz18 months ago

  • Keywords has-patch added
  • Severity changed from normal to minor

comment:2 @SergeyBiryukov18 months ago

  • Keywords 3.9-early added
  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to lowest
  • Severity changed from minor to trivial
  • Version changed from trunk to 3.6

Related: [24042]

comment:3 @ocean9018 months ago

What do you mean by "HTML tag standard compliant"?

Since we doesn't have a XML document here I'm fine with just <br>. There is really no need to "fix" such things.

See also http://www.w3.org/TR/html5/text-level-semantics.html#the-br-element.

comment:4 @Latz18 months ago

You're right, I thought HTML5 would require properly closing all tags. Nevertheless there are the "WordPress Coding standards": Self-closing Elements (http://make.wordpress.org/core/handbook/coding-standards/html/#self-closing-elements). Secondly it's the only br tag in the whole code base that's not self closed. So at least it should be fixed for consistency.

comment:5 follow-up: @ocean9018 months ago

Secondly it's the only br tag in the whole code base that's not self closed.

There are two more in JS files:

comment:6 in reply to: ↑ 5 @Latz17 months ago

Replying to ocean90:

There are two more in JS files:

Does that mean you would support the ticket if those were changed, too?

comment:7 @jeremyfelt16 months ago

  • Component changed from Administration to Posts, Post Types
  • Focuses admin added

comment:8 @wonderboymusic5 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed via hackificator cleanup in [28497]

comment:9 @ocean904 months ago

  • Milestone changed from Future Release to 4.2
Note: See TracTickets for help on using tickets.