WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#26608 closed defect (bug) (fixed)

/wp-admin/includes/post.php: Make HTML tag standard compliant

Reported by: Latz Owned by:
Priority: lowest Milestone: 4.2
Component: Posts, Post Types Version: 3.6
Severity: trivial Keywords: has-patch 3.9-early
Cc: Focuses: administration

Description

<br> tag isn't closed.

Attachments (1)

26608.diff​ (695 bytes ) - added by Latz 13 years ago.

Download all attachments as: .zip

Change History (10)

@Latz
13 years ago

#1 @Latz
13 years ago

  • Keywords has-patch added
  • Severity normal → minor

#2 @SergeyBiryukov
13 years ago

  • Keywords 3.9-early added
  • Milestone Awaiting Review → Future Release
  • Priority normal → lowest
  • Severity minor → trivial
  • Version trunk → 3.6

Related: [24042]

#3 @ocean90
13 years ago

What do you mean by "HTML tag standard compliant"?

Since we doesn't have a XML document here I'm fine with just <br>. There is really no need to "fix" such things.

See also ​http://www.w3.org/TR/html5/text-level-semantics.html#the-br-element.

#4 @Latz
13 years ago

You're right, I thought HTML5 would require properly closing all tags. Nevertheless there are the "WordPress Coding standards": Self-closing Elements (​http://make.wordpress.org/core/handbook/coding-standards/html/#self-closing-elements). Secondly it's the only br tag in the whole code base that's not self closed. So at least it should be fixed for consistency.

#5 follow-up: @ocean90
13 years ago

Secondly it's the only br tag in the whole code base that's not self closed.

There are two more in JS files:

#6 in reply to: ↑ 5 @Latz
13 years ago

Replying to ocean90:

There are two more in JS files:

Does that mean you would support the ticket if those were changed, too?

#7 @jeremyfelt
13 years ago

  • Component Administration → Posts, Post Types
  • Focuses admin added

#8 @wonderboymusic
12 years ago

  • Resolution → fixed
  • Status new → closed

Fixed via hackificator cleanup in [28497]

#9 @ocean90
12 years ago

  • Milestone Future Release → 4.2
Note: See TracTickets for help on using tickets.