themes.php: Weird cursor behaviour in disabled element

[Latz]

If you're at the first or last theme in the theme details popup one of the arrows is disabled. If the cursor moves over the disabled arrow it changes to text style.

Two possible solutions:
a) Cursor changes to "pointer"
b) Cursor doesn't change at all and stays default.

[matveb]

Setting user-select to none on the disabled class should be enough.

[bcworkz]

cursor: default; does it. Some of you ought to poke about and be sure this doesn't do something funky elsewhere. I couldn't find anything, but...

[obenland]

I can't reproduce the text cursor in latest Chrome and FF. The element is still focusable though.
Can we instead of (or in addition to) adding the disabled class, add an actual disabled attribute?

[Latz]

Replying to obenland:

I can't reproduce the text cursor in latest Chrome and FF. The element is still focusable though.

You're right, the text cursor problem has gone. Seems to have been a browser error (for my shame I just tested it only in FF).

[obenland]

26611.diff​ actually disables the buttons. This also stops them from being focusable.

The navigation elements in the theme installer preview are anchors, not buttons, so that approach doesn't work for them.
We could bring them en par with the theme screen, but I'm not sure what side effects that could trigger.

[SergeyBiryukov]

26611.diff​ has a side effect.

Currently, if you press Shift+Tab several times, the inactive arrow can be focused, but you can't tab out of the modal.

With the patch, you can tab out of the overlay. See [26922] for the original keyboard accessibility commit.

[obenland]

Replying to SergeyBiryukov:

Currently, if you press Shift+Tab several times, the inactive arrow can be focused, but you can't tab out of the modal.
With the patch, you can tab out of the overlay. See [26922] for the original keyboard accessibility commit.

Good catch, I was not aware of that. I'll close the ticket then, as the original bug is not reproducible anymore.