WordPress.org

Make WordPress Core

#26614 closed defect (bug) (fixed)

Plural forms for "See more" string on Dashboard

Reported by: SergeyBiryukov Owned by: johnbillion
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.8
Component: I18N Keywords: has-patch 3.9-early commit
Focuses: Cc:

Description

'See %s more...' string on Dashboard should use _n() for proper i18n.

Attachments (2)

26614.patch (827 bytes) - added by SergeyBiryukov 16 months ago.
26614.2.patch (2.7 KB) - added by johnbillion 13 months ago.
Removes the 'See more' functionality altogether

Download all attachments as: .zip

Change History (16)

@SergeyBiryukov16 months ago

comment:1 @pavelevap16 months ago

Yes, I noticed the same thing, but could not find a way how to change default number of 3 more, so I expected that it is not possible to change it and there is no need for plural forms. How can I change this number?

comment:2 @SergeyBiryukov16 months ago

The number of posts to display by default is 2, and the maximum number is 5, hardcoded in wp_dashboard_site_activity(): tags/3.8/src/wp-admin/includes/dashboard.php#L516.

If you have more than 5 posts, the link always says "See 3 more".

However, if you have 3 or 4 posts, the link says "See 1 more" and "See 2 more", so the plural forms are still needed.

Last edited 16 months ago by SergeyBiryukov (previous) (diff)

comment:3 follow-up: @pavelevap16 months ago

Thank you, Sergey! I did not notice it...

And "Configure" link for customizing settings of some Dashboard widgets was removed? I do not see it on any widget, but it is part of Help text...

comment:4 in reply to: ↑ 3 ; follow-up: @SergeyBiryukov16 months ago

Replying to pavelevap:

And "Configure" link for customizing settings of some Dashboard widgets was removed? I do not see it on any widget, but it is part of Help text...

Yeah, the help text should be updated.

comment:5 follow-up: @johnbillion16 months ago

On a related note, I don't see the benefit of the "See %s more" link in the first place. Showing two posts with a link to show three more seems pointless. Why don't we just show five in the first place? It's not like we're short of space on the dashboard.

comment:6 in reply to: ↑ 5 @pavelevap16 months ago

Replying to johnbillion:

On a related note, I don't see the benefit of the "See %s more" link in the first place. Showing two posts with a link to show three more seems pointless. Why don't we just show five in the first place? It's not like we're short of space on the dashboard.

+1

Remove it completely. There are only misunderstandings and problems with this link. If it would be configurable, maybe, but show 2 and allow only next 3 is pointless.

comment:7 @nacin16 months ago

  • Milestone changed from Future Release to 3.8.1

3.8.1 for consideration and tracking purposes.

comment:8 in reply to: ↑ 4 @kpdesign16 months ago

Replying to SergeyBiryukov:

Replying to pavelevap:

And "Configure" link for customizing settings of some Dashboard widgets was removed? I do not see it on any widget, but it is part of Help text...

Yeah, the help text should be updated.

See #26632 for patch to update help text.

comment:9 @nacin15 months ago

  • Milestone changed from 3.8.1 to 3.9

I think it is safe to fix this in 3.9.

If we keep it, one option is to change this to just "See more..."

@johnbillion13 months ago

Removes the 'See more' functionality altogether

comment:10 follow-ups: @johnbillion13 months ago

Personally I think the "See more" link in this dashboard widget is completely pointless. 26614.2.patch removes it and displays all five posts in both sections.

comment:11 in reply to: ↑ 10 @DrewAPicture13 months ago

Replying to johnbillion:

Personally I think the "See more" link in this dashboard widget is completely pointless. 26614.2.patch removes it and displays all five posts in both sections.

I agree. Seems like it would make more sense if somebody was querying for many many more posts, but even then, this doesn't seem like the ideal venue to view those anyway.

comment:12 in reply to: ↑ 10 @SergeyBiryukov13 months ago

Replying to johnbillion:

Personally I think the "See more" link in this dashboard widget is completely pointless. 26614.2.patch removes it and displays all five posts in both sections.

I'd also tend to agree.

comment:13 @SergeyBiryukov13 months ago

  • Keywords commit added

comment:14 @johnbillion13 months ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 27583:

Remove the "See more" toggle from the At a Glance dashboard widget. Fixes #26614.

Note: See TracTickets for help on using tickets.