WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 8 weeks ago

Last modified 2 weeks ago

#26617 closed defect (bug) (fixed)

Wrong example for Dashicons in add_menu_page() docs

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.8
Component: Administration Keywords: has-patch commit fixed-major
Focuses: docs Cc:

Description

As reported by Rarst in #25147, inline docs went into release suggesting dashicons-piechart example, but the actual CSS is now dashicons-chart-pie.

Related: [26664] (for #25147), [26752] (for #26227).

Attachments (2)

26617.patch​ (849 bytes) - added by SergeyBiryukov 3 months ago.
26617.2.patch​ (1.8 KB) - added by SergeyBiryukov 3 months ago.

Download all attachments as: .zip

Change History (8)

SergeyBiryukov — 3 months ago

SergeyBiryukov — 3 months ago

comment:2 SergeyBiryukov — 2 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26884:

Use correct example of a Dashicons helper class in add_menu_page() and register_post_type() docs.

props Rarst.
fixes #26617 for trunk.

comment:3 SergeyBiryukov — 2 months ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:4 nacin — 8 weeks ago

  • Milestone changed from 3.8.1 to 3.9
  • Resolution set to fixed
  • Status changed from reopened to closed

It doesn't look like we're going to touch either of these files otherwise in 3.8.1; I think it is quite safe to wait for 3.9 and avoid the churn.

comment:5 DrewAPicture — 2 weeks ago

  • Focuses docs added

comment:6 DrewAPicture — 2 weeks ago

  • Component changed from Inline Docs to Administration
Note: See TracTickets for help on using tickets.