Word Count is one number short

[jorbin]

Write a post. The count will be one number too low in text view if you don't press enter.
For example:

This is some content. It should be ten words long.

The counter shows that being 9 words.

related: #6991

[jorbin]

Unit Test

[jorbin]

The above patch includes both a fix and a unit test.

I'm not sure if I am correctly checking for being in txt mode vs being in tinymce mode. Is there a better way to get this information?

[nacin]

Replying to jorbin:

I'm not sure if I am correctly checking for being in txt mode vs being in tinymce mode. Is there a better way to get this information?

Appears to be this: typeof tinyMCE != 'undefined' && ( ed = tinyMCE.activeEditor ) && !ed.isHidden() ) {

[nacin]

Two possible alternative fixes that are not editor-dependent:

• Add a space to the end of tx prior to running the count.

• Use /\S(\s+|$)/gm instead (untested).

[nacin]

Also, 26620.2.diff​ has JSHint errors. :-)

[jorbin]

Padding a space on to the end seemed simpler than changing the regex and works independent of the editor. New patch does that.

JSHint errors fixed.

[wonderboymusic]

No Dice.

[kirasong]

Due RC coming shortly, because this patch's tests don't cleanly apply and the current patch still seems to have the bug above, moving to future release.

[iseulde]

In 32856:

Editor: restructure word count

• The WordCounter should only do one thing: count words. This makes it also easier to test.
• Add some really basic unit tests.
• Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
• Use match instead of replace when it is appropriate.
• More readable code.

See #30966. Fixes #26620.