get_queried_object does not test anymore for existence of terms in tax_query

[Chouby]

This may result in PHP errors:

PHP Warning:  reset() expects parameter 1 to be array, null given in /wp-includes/query.php on line 3277
PHP Notice:  Undefined index: taxonomy in /wp-includes/query.php on line 3277

This appears to be a regression introduced in WP 3.8 by [26007] for #20767.

[wonderboymusic]

I believe you, but what query caused this? I would like to add another unit test for it

[Chouby]

@wonderboymusic I remove a custom taxonomy from the query in a parse_query filter

add_filter('parse_query', 'remove_my_tax');
function remove_my_tax($query) {
	$qvars = &$query->query_vars;
	unset ($qvars['my-tax']); // 'my-tax' is a custom taxonomy query var
}

[wonderboymusic]

Fixed in [26864].

[nacin]

Re-opening to be code-reviewed and considered for inclusion in 3.8.1.

[layotte]

Submitted patch here #26728 which fixes bug in [26864]

[SergeyBiryukov]

[26874] fixes the bug in [26864].

[nacin]

[26946] for 3.8.1.