WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#26647 closed defect (bug) (fixed)

Similar strings in Twenty Fourteen

Reported by: pavelevap Owned by: lancewillett
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Attachments (1)

26647.diff (1.1 KB) - added by celloexpressions 6 years ago.
Standardize the featured content section description string

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 3.9
  • Version changed from trunk to 3.8

From my testing, the one in Featured_Content::customize_register() is never displayed in the UI, the one in twentyfourteen_customize_register() overrides it.

#2 @pavelevap
7 years ago

Yes, exactly, maybe the whole $wp_customize->add_section part could be removed? Not sure about that...

#3 @lancewillett
7 years ago

  • Milestone changed from 3.9 to Future Release

#4 @lancewillett
7 years ago

  • Keywords needs-patch added
  • Milestone changed from Future Release to 3.9

@celloexpressions
6 years ago

Standardize the featured content section description string

#5 @celloexpressions
6 years ago

  • Keywords has-patch added; needs-patch removed

I think we need to add the section in both places, since we're adding controls to it in both places. I believe this was done to allow the Featured Content file to be easily used in other themes, with the Twenty Fourteen-specific option defined separately in the theme.

Patch standardizes both places to use the shorter string, from twentyfourteen_customize_register().

#6 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 27573:

Twenty Fourteen: merge two similar strings in Customizer featured content help text. Props celloexpressions, fixes #26647.

Note: See TracTickets for help on using tickets.