Opened 11 years ago
Closed 11 years ago
#26647 closed defect (bug) (fixed)
Similar strings in Twenty Fourteen
Reported by: | pavelevap | Owned by: | lancewillett |
---|---|---|---|
Milestone: | 3.9 | Priority: | normal |
Severity: | normal | Version: | 3.8 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
I am not sure if there is any hidden meaning for both strings, but I did not find anything. Could we merge these long strings?
Attachments (1)
Change History (7)
#2
@
11 years ago
Yes, exactly, maybe the whole $wp_customize->add_section part could be removed? Not sure about that...
#5
@
11 years ago
- Keywords has-patch added; needs-patch removed
I think we need to add the section in both places, since we're adding controls to it in both places. I believe this was done to allow the Featured Content file to be easily used in other themes, with the Twenty Fourteen-specific option defined separately in the theme.
Patch standardizes both places to use the shorter string, from twentyfourteen_customize_register()
.
Note: See
TracTickets for help on using
tickets.
From my testing, the one in
Featured_Content::customize_register()
is never displayed in the UI, the one intwentyfourteen_customize_register()
overrides it.