WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 3 months ago

#26658 closed defect (bug) (fixed)

Quick Draft list overflow issue

Reported by: aubreypwd Owned by: nacin
Milestone: 3.8.1 Priority: normal
Severity: normal Version: 3.8
Component: Administration Keywords: has-patch fixed-major
Focuses: ui Cc:

Description

If someone puts a full line of text (can happen with a shortcode, see https://cloudup.com/cDELlimbvKk) in a draft, in the list below the Quick Draft panel on the dashnoard, the text can flow outside of the box (also see https://cloudup.com/cDELlimbvKk).

See http://lists.automattic.com/pipermail/wp-testers/2013-December/014607.html for the original report.

I've added the CSS to the patch that fixes it. Thanks to Brent Logan for the find!

Attachments (2)

26658-word-wrap.patch (390 bytes) - added by aubreypwd 4 months ago.
Fix using suggested word-wrap method
26658.patch (347 bytes) - added by aubreypwd 4 months ago.
Modified patch based on http://core.trac.wordpress.org/ticket/26658#comment:7

Download all attachments as: .zip

Change History (12)

comment:1 aubreypwd4 months ago

I also tested and made sure it didn't affect other draft items in the list. https://cloudup.com/cIKgNZ2Bof7

comment:2 nacin4 months ago

  • Component changed from General to Administration
  • Milestone changed from Awaiting Review to 3.8.1

comment:3 SergeyBiryukov4 months ago

  • Keywords ui-focus has-patch added
  • Version changed from trunk to 3.8

Previously: #17424

comment:4 SergeyBiryukov4 months ago

Would it make sense to use word-wrap: break-word, like we did in [19694]?

aubreypwd4 months ago

Fix using suggested word-wrap method

comment:5 aubreypwd4 months ago

Has this result: https://cloudup.com/cjEDt6Ob8EW

If the shortcode or textwrittenthiscrazyway was super duper long it could be...messy. Included patch anyways.

comment:6 aubreypwd4 months ago

I thought maybe do a strip_shortcodes but if the shortcode isn't active, it still shows it, and textwrittenthiswayIdontknowwhyanywonewoulddothis still shows too.

comment:7 SergeyBiryukov4 months ago

https://cloudup.com/cjEDt6Ob8EW looks good enough to me.

The new rule can be combined with the existing one: tags/3.8/src/wp-admin/css/wp-admin.css#L3157.

comment:8 helen3 months ago

In 26928:

Break long words in Quick Draft content to prevent ugly overflow, as was previously done. props aubreypwd, SergeyBiryukov. see #26658 for trunk.

comment:9 helen3 months ago

  • Keywords fixed-major added

comment:10 nacin3 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26948:

Break long words in Quick Draft content to prevent ugly overflow, as was previously done.

Merges [26928] to the 3.8 branch.

props aubreypwd, SergeyBiryukov.
fixes #26658.

Note: See TracTickets for help on using tickets.