Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 13 years ago

Closed 13 years ago

#26666 closed defect (bug) (fixed)

Text in built-in file editor is RTL instead of LTR

Reported by:	Revital	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	3.8.1
Component:	RTL	Version:	3.8
Severity:	normal	Keywords:	has-patch commit fixed-major
Cc:		Focuses:

Description

Upgraded to 3.8 - Hebrew (RTL) version - and went to Appearance -- > Editor. The text in the textarea is aligned to the right and RTL, instead of LTR.

This also happens in the plugin editor screen.

Previous versions did not have this bug.

In general, code editing should always be LTR and aligned to the left, since it's mostly in English.

Attached is a screenshot.

Attachments (3)

file_editor.jpg (196.5 KB ) - added by Revital 13 years ago.
26666.patch (465 bytes ) - added by SergeyBiryukov 13 years ago.
26666.2.patch (539 bytes ) - added by nivijah 13 years ago.: Added "@noflip" to prevent overwriting

Download all attachments as: .zip

Change History (13)

@Revital
13 years ago

Attachment file_editor.jpg added

@SergeyBiryukov
13 years ago

Attachment 26666.patch added

#1 @SergeyBiryukov
13 years ago

Component General → RTL
Keywords has-patch added
Milestone Awaiting Review → 3.8.1

Broken in [26107].

Some styles were added in [19087] and [19816] to wp-admin-rtl.css, but were missing in wp-admin.css.

@nivijah
13 years ago

Attachment 26666.2.patch added

Added "@noflip" to prevent overwriting

#2 @yoavf
13 years ago

Cc yoavf added

#3 @yoavf
13 years ago

Cc nivijah added

#4 @SergeyBiryukov
13 years ago

Good point on adding @noflip in 26666.2.patch , forgot about that.

#5 @maor
13 years ago

Cc maorhaz@… added

#6 @alex-ye
13 years ago

Cc nashwan.doaqan@… added

#7 @ramiy
13 years ago

Related: #25577.

#8 @SergeyBiryukov
13 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

Force LTR direction for code and plugin/theme editors.

props SergeyBiryukov, nivijah.
fixes #26666 for trunk.

#9 @SergeyBiryukov
13 years ago

Keywords commit fixed-major added
Resolution fixed
Status closed → reopened

#10 @nacin
13 years ago

Resolution → fixed
Status reopened → closed

Force LTR direction for code and plugin/theme editors.

Merges [26888] to the 3.8 branch.

props SergeyBiryukov, nivijah.
fixes #26666.

Note: See TracTickets for help on using tickets.

Download in other formats: