WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#26666 closed defect (bug) (fixed)

Text in built-in file editor is RTL instead of LTR

Reported by: Revital Owned by: SergeyBiryukov
Milestone: 3.8.1 Priority: normal
Severity: normal Version: 3.8
Component: RTL Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

Upgraded to 3.8 - Hebrew (RTL) version - and went to Appearance -- > Editor. The text in the textarea is aligned to the right and RTL, instead of LTR.

This also happens in the plugin editor screen.

Previous versions did not have this bug.

In general, code editing should always be LTR and aligned to the left, since it's mostly in English.

Attached is a screenshot.

Attachments (3)

file_editor.jpg (196.5 KB) - added by Revital 5 years ago.
26666.patch (465 bytes) - added by SergeyBiryukov 5 years ago.
26666.2.patch (539 bytes) - added by nivijah 5 years ago.
Added "@noflip" to prevent overwriting

Download all attachments as: .zip

Change History (13)

@Revital
5 years ago

#1 @SergeyBiryukov
5 years ago

  • Component changed from General to RTL
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.8.1

Broken in [26107].

Some styles were added in [19087] and [19816] to wp-admin-rtl.css, but were missing in wp-admin.css.

@nivijah
5 years ago

Added "@noflip" to prevent overwriting

#2 @yoavf
5 years ago

  • Cc yoavf added

#3 @yoavf
5 years ago

  • Cc nivijah added

#4 @SergeyBiryukov
5 years ago

Good point on adding @noflip in 26666.2.patch, forgot about that.

#5 @maor
5 years ago

  • Cc maorhaz@… added

#6 @alex-ye
5 years ago

  • Cc nashwan.doaqan@… added

#7 @ramiy
5 years ago

Related: #25577.

#8 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26888:

Force LTR direction for code and plugin/theme editors.

props SergeyBiryukov, nivijah.
fixes #26666 for trunk.

#9 @SergeyBiryukov
5 years ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#10 @nacin
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 26954:

Force LTR direction for code and plugin/theme editors.

Merges [26888] to the 3.8 branch.

props SergeyBiryukov, nivijah.
fixes #26666.

Note: See TracTickets for help on using tickets.