WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#26668 closed defect (bug) (fixed)

Small widget strings optimization

Reported by: pavelevap Owned by: johnbillion
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.8
Component: Text Changes Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

See attached patch for details.

  • "Search" string for default widget needs a context (noun), in other places it is verb.
  • Missing point in 2014, all widgets have points in the end.
  • One not needed comma.

Not in patch: Tag cloud should be Taxonomy cloud now?

Attachments (2)

widget_strings.patch (1.7 KB) - added by pavelevap 6 years ago.
26668.1.diff (1.7 KB) - added by Hanni 6 years ago.
Patch to maintain pavelevap's changes but restore oxford comma.

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 3.9
  • Version changed from trunk to 3.8

One not needed comma.

I think that's an Oxford comma.

#2 @pavelevap
6 years ago

Interesting, I did not know about that, it is wrong way in our language :-)

Comma can be preserved, but I would change ampersand entity to "and" in this case.

@Hanni
6 years ago

Patch to maintain pavelevap's changes but restore oxford comma.

#3 @Hanni
6 years ago

  • Keywords has-patch added

Opinion is divided on the use of Oxford (or serial) commas and ampersands, but, for the sake of both consistency and the timing in the release cycle here is the "fix" suggested by @SergeyBiryukov for @pavelevap's original patch.

#5 @SergeyBiryukov
6 years ago

  • Keywords commit added

#6 @SergeyBiryukov
6 years ago

  • Summary changed from Small widget strings optimalization to Small widget strings optimization

#7 @johnbillion
6 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 27412:

Add context and a missing period to widget descriptions. Fixes #26668. Props pavelevap, Hanni

Note: See TracTickets for help on using tickets.