Make WordPress Core

Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#2667 closed defect (bug) (fixed)

The JS delete confirm box doesn't show when you search in "manage pages"

Reported by: playr's profile PlayR Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.0.2
Component: Administration Keywords: id, search, manage pages, delete message
Focuses: Cc:

Description

When you manage a page in the administration you can make a search.
If you do so the page ID is missing in the delete confim box (Are you sure - box).
I can see that you have fixed a bug recently because in a ealier version it was all the ID's in the search that was missing. Yuo just forgot this one.

Line 55 in wp-admin/edit-pages.php:
$id should be replaced with $post->ID

Change History (4)

#1 @davidhouse
18 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

I can't replicate. In the "Are you sure" dialog, no ID is present with or without searching. Pressing "OK" confirms and the delete goes through.

Reopen if you can be more precise in what you mean.

#2 @PlayR
18 years ago

  • Resolution worksforme deleted
  • Status changed from closed to reopened

Okay..
I dont get the confirm.

Line 55:
<td><?php if ( current_user_can('edit_pages') ) { echo "<a href='post.php?action=delete&amp;post=$post->ID' class='delete' onclick=\"return deleteSomething( 'page', " . $id . ", '" . sprintf(("You are about to delete the &quot;%s&quot; page.
n&quot;OK&quot; to delete, &quot;Cancel&quot; to stop."), wp_specialchars(get_the_title(,,0), 1)) . "' );\">" .
('Delete') . "</a>"; } ?></td>

Here you can see the line. If I replace $id with $post->ID I get the confim box.
(this is from a clean WP 2.0.2)

I will reopen it one time. It is wierd that I am the only one that has the "bug".

#3 @mdawaffe
18 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Already fixed in trunk: [3564].

#4 @(none)
18 years ago

  • Milestone 2.0.2 deleted

Milestone 2.0.2 deleted

Note: See TracTickets for help on using tickets.