WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#26713 closed defect (bug) (fixed)

Fix @since tags to use the 3-digit x.x.x style everywhere

Reported by: JustinSainton Owned by: DrewAPicture
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.8
Component: General Keywords: has-patch
Focuses: docs Cc:
PR Number:

Attachments (5)

26713.diff (879 bytes) - added by JustinSainton 6 years ago.
Updates doc blocks to @since 3.0.0
26713.1.diff (522 bytes) - added by JustinSainton 6 years ago.
Some people like the sidebar in 2012
26713.2.diff (52.6 KB) - added by SergeyBiryukov 6 years ago.
26713.3.diff (46.2 KB) - added by DrewAPicture 6 years ago.
3-digit x.x.x versions all the places
26713.4.diff (55.5 KB) - added by DrewAPicture 6 years ago.
Moar

Download all attachments as: .zip

Change History (16)

@JustinSainton
6 years ago

Updates doc blocks to @since 3.0.0

#1 @JustinSainton
6 years ago

  • Keywords has-patch added

@JustinSainton
6 years ago

Some people like the sidebar in 2012

#2 follow-up: @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 3.9

Let's do it consistently then :) 26713.2.diff. Skipped a few libraries:

wp-admin/includes/class-ftp-pure.php
wp-admin/includes/class-ftp-sockets.php
wp-admin/includes/class-ftp.php
wp-includes/atomlib.php
wp-includes/class-IXR.php
wp-includes/class-phpass.php
wp-includes/class-simplepie.php

#3 @JustinSainton
6 years ago

Merry Christmas, SergeyBot :)

#4 in reply to: ↑ 2 @DrewAPicture
6 years ago

Replying to SergeyBiryukov:

Let's do it consistently then :) 26713.2.diff. Skipped a few libraries:

wp-admin/includes/class-ftp-pure.php
wp-admin/includes/class-ftp-sockets.php
wp-admin/includes/class-ftp.php
wp-includes/atomlib.php
wp-includes/class-IXR.php
wp-includes/class-phpass.php
wp-includes/class-simplepie.php

Skipped more than a few. I'm working on it.

@DrewAPicture
6 years ago

3-digit x.x.x versions all the places

#5 @DrewAPicture
6 years ago

If we choose to go down the route of fixing all of the non-3-digit @since versions (and I think we should), 26713.3.diff will get us there.

#6 @SergeyBiryukov
6 years ago

26713.3.diff is missing some of the changes to @deprecated in wp-includes/deprecated.php that 26713.2.diff has (lines 56, 162, 390, etc.)

@DrewAPicture
6 years ago

Moar

#7 @DrewAPicture
6 years ago

  • Description modified (diff)
  • Summary changed from Improper @since tags in two places in wp-activate.php to Fix @since tags to use the 3-digit x.x.x style everywhere

#8 @DrewAPicture
6 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 26868:

First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.

Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.

#9 @SergeyBiryukov
6 years ago

In 26869:

Being consistent is the gist, no single @since should have been missed.

see #26713.

#10 @DrewAPicture
6 years ago

  • Focuses docs added

#11 @DrewAPicture
6 years ago

  • Component changed from Inline Docs to General
Note: See TracTickets for help on using tickets.