#26722 closed defect (bug) (fixed)
Quick Draft ignores default comment_status and ping_status
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.8.1 | Priority: | normal |
Severity: | normal | Version: | 3.8 |
Component: | Administration | Keywords: | has-patch |
Focuses: | Cc: |
Description
This is a regression introduced in r26144. The old Quick Press save and publish actions both set comment_status
and ping_status
explicitly before running edit_post()
. To reproduce:
- Set default comment status to open in Settings - Discussion
- Create a new draft using Quick Draft
- Edit the newly created draft and see comment status
Attachments (1)
Change History (7)
#4
@
11 years ago
edit_post() can receive an array of $post_data, otherwise it uses $_POST. But it uses $_POST by reference, so this does appear it would change behavior in some why. (Why does it use it byref? No idea, and should ideally be investigated and removed.) Fine with this for now.
Note: See
TracTickets for help on using
tickets.
26722.diff brings a couple lines back from the
post-quickpress-save
action topost-quickdraft-save
. I don't think modifying the$_POST
superglobal is the best solution, but that's what worked before we broke it.