WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#26722 closed defect (bug) (fixed)

Quick Draft ignores default comment_status and ping_status

Reported by: kovshenin Owned by: nacin
Milestone: 3.8.1 Priority: normal
Severity: normal Version: 3.8
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

This is a regression introduced in r26144. The old Quick Press save and publish actions both set comment_status and ping_status explicitly before running edit_post(). To reproduce:

  1. Set default comment status to open in Settings - Discussion
  2. Create a new draft using Quick Draft
  3. Edit the newly created draft and see comment status

Attachments (1)

26722.diff (556 bytes) - added by kovshenin 5 years ago.

Download all attachments as: .zip

Change History (7)

@kovshenin
5 years ago

#1 @kovshenin
5 years ago

  • Keywords has-patch added

26722.diff brings a couple lines back from the post-quickpress-save action to post-quickdraft-save. I don't think modifying the $_POST superglobal is the best solution, but that's what worked before we broke it.

#2 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 3.8.1

#3 @markjaquith
5 years ago

I'm fine with that approach in 3.8.1 at least.

#4 @nacin
5 years ago

edit_post() can receive an array of $post_data, otherwise it uses $_POST. But it uses $_POST by reference, so this does appear it would change behavior in some why. (Why does it use it byref? No idea, and should ideally be investigated and removed.) Fine with this for now.

#5 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26959:

Don't let Quick Draft ignore default comment_status and ping_status.

props kovshenin.
fixes #26722.

#6 @nacin
5 years ago

In 26960:

Don't let Quick Draft ignore default comment_status and ping_status.

Merges [26959] to the 3.8 branch.

props kovshenin.
fixes #26722.

Note: See TracTickets for help on using tickets.