WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#26731 closed defect (bug) (fixed)

Custom Backgrounds Preview Callback replaces too much

Reported by: obenland's profile obenland Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.0
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

Instead of just replacing the content of the table cell with the custom background preview, it also replaces the section heading and the form table head.

See ​custom header vs. ​custom background.
Introduced in r14209.
​IRC log discussing the best way to fix it.

Attachments (1)

26731.diff​ (3.2 KB) - added by obenland 10 years ago.

Download all attachments as: .zip

Change History (3)

@obenland
10 years ago

#1 @SergeyBiryukov
10 years ago

Also noticed that id="custom-background" (introduced in [13303]) is no longer used since [17885] and can probably be removed.

#2 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26878:

Always show Background Image section heading and the opening table tag on Custom Background screen, to make in consistent with Custom Header and avoid broken markup.

props obenland.
fixes #26731.

Note: See TracTickets for help on using tickets.