Twenty Fourteen "featured" tag not hidden on frontend as expected

[Chouby]

To reproduce, just activate Twenty Fourteen on a fresh install (optionally visit the customizer to check that the featured tag is "featured" and is not displayed on frontend as default. You are happy with that so do not make any changes).

Create a new post with tag "featured". The "featured" tag appears in the list of tags as well as in the tag cloud.

[Chouby]

The patch just proposes to fill featured content settings at theme activation to deal with the case when the featured tag is existing before theme activation.

[celloexpressions]

I can confirm that the "featured" tag is not hidden unless you change the option to a different tag, then back to "featured".

[Chouby]

26732.patch isn't good as it fires a fatal error

Call to undefined function wp_create_tag() in wp-content/themes/twentyfourteen/inc/featured-content.php on line 517

if the featured tag does not exist

[Chouby]

26732.patch isn't good as it fires a fatal error

Should be fixed by 26732.2.patch

NB: I also noticed that it is impossible to delete the "featured" tag (as it is immediately re-created by the function Featured_Content::validate_settings(). Don't know if it is a wanted feature or a bug (as might suggest the comment for Featured_Content::delete_post_tag() :

Reset tag option when the saved tag is delete

[obenland]

Patch adds a check for the tag name, in case we're using default values and the default id of 0 does not match the term id of the featured tag.

[lancewillett]

In 27118:

Twenty Fourteen: make sure featured tag is hidden on front-end views as expected. Add a check for the tag name in case we're using default values and the default ID of 0 does not match the term id of the featured tag.

Props obenland, fixes #26732.

[lancewillett]

This isn't major. :)

[lancewillett]

Testing note, for Obenland and Jetpack plugin team -- with Jetpack enabled the "Hide tag from tag clouds and post meta" doesn't seem to be working correctly. Works fine with trunk and Twenty Fourteen without Jetpack active.

[lancewillett]

Note: Fix for Jetpack is in the works.

[SergeyBiryukov]

Replying to lancewillett:

This isn't major. :)

We use "fixed-major" keyword for tickets fixed in the major release and reopened for minor release consideration :) ​http://make.wordpress.org/core/2011/04/06/the-keywords-fixed-major-and-fixed/

[nacin]

lancewillett and I decided that we would be leaving all bundled theme tickets for 3.9. Given the timeline (and lack of severity) we won't be doing a theme update before then.