WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#26743 closed defect (bug) (fixed)

width for comment_type in wp-admin comments table is not enough for german translation

Reported by: Kniebremser Owned by:
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.5
Component: Comments Keywords: has-patch
Focuses: ui, administration Cc:

Description

The current max width of 200px in .tablenav .actions select is not enough for the german translation. With 220px, it looks very good.

Sorry, my english is not very good.

Attachments (3)

26743.patch (614 bytes) - added by SergeyBiryukov 2 years ago.
26743.2.patch (1.7 KB) - added by ocean90 2 years ago.
26743.png (15.6 KB) - added by ocean90 2 years ago.

Download all attachments as: .zip

Change History (13)

#1 @SergeyBiryukov
2 years ago

  • Component changed from Menus to Administration
  • Keywords ui-focus added
  • Milestone changed from Awaiting Review to 3.9

Introduced in [21916].

#2 @SergeyBiryukov
2 years ago

  • Version changed from 3.8 to 3.5

#3 @SergeyBiryukov
2 years ago

  • Keywords has-patch added

#4 @jeremyfelt
2 years ago

  • Component changed from Administration to Comments
  • Focuses admin added

#5 @nacin
2 years ago

min-width seems like it would make more sense here, as we're not dealing with strings that are completely user-defined (like categories) and thus wouldn't go on forever. That said, I'd like to see the German translation team come up with a shorter way to say "Show all comment types", such as by translating "Show types" or something.

#6 @Kniebremser
2 years ago

When the German translation team makes the change, I can live with that.
The ticket as I'm concerned can be closed.

@ocean90
2 years ago

#7 @ocean90
2 years ago

In 27626:

Remove "Show" prefix from filter dropdowns, see #26743.

@ocean90
2 years ago

#8 follow-up: @ocean90
2 years ago

  • Keywords close added

[27626] removes the "Show" prefix. "Show" is more an action, but it's not really an action here. That means we can reduce the translation by one word too. See 26743.png, the width is now ~180px.

Seems like a good compromise.

#9 in reply to: ↑ 8 @Kniebremser
2 years ago

Replying to ocean90:

[27626] removes the "Show" prefix. "Show" is more an action, but it's not really an action here. That means we can reduce the translation by one word too. See 26743.png, the width is now ~180px.

Seems like a good compromise.

It's a good compromise. +1

#10 @ocean90
2 years ago

  • Keywords close removed
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.