WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#26748 closed defect (bug) (fixed)

Widget's arrow does not change between open or closed

Reported by: senff Owned by: ocean90
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.8
Component: Widgets Keywords: has-patch
Focuses: Cc:

Description

Although the arrows for the sidebars change between open and closed (arrow points up when sidebar is open, and points down when sidebar is closed), it does not work the same for any widgets that are in a sidebar. The arrow is consistently pointing down, regardless of the widget being open or closed.

Reproduce: in APPEARANCE -> WIDGETS, drag any widget to any sidebar, then click on the arrow to open/close the widget and see it's settings. The arrow will remain pointing down.

Expected: arrow points down when widget is closed and arrow points up when widget is open.

Attachments (2)

26748.diff (996 bytes) - added by MikeHansenMe 6 years ago.
26748.2.diff (1.5 KB) - added by shaunandrews 6 years ago.

Download all attachments as: .zip

Change History (7)

#1 @jdgrimes
6 years ago

  • Cc jdg@… added

@MikeHansenMe
6 years ago

#2 @MikeHansenMe
6 years ago

  • Keywords has-patch needs-testing added

@shaunandrews
6 years ago

#3 follow-up: @shaunandrews
6 years ago

I tested the 26748.diff​ patch, and it seems to work well.

One thing I noticed while working with widgets (in both personal experience and with some user tests) is that its not obvious which widgets are "opened" — having the arrow change direction helps, but I think changing the background color of the .widget-top would make it instantly noticeable.

https://i.cloudup.com/NaT5ZmIhjz.png

26748.2.diff​ does just this — I wanted to make the opened .widget-top use the current color scheme's highlight color, so I used some JS to grab this color from the menu. Its a little hacky, but it we like it, we could replace the JS trickery by updating the color scheme component.

#4 @ocean90
6 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 28235:

Widgets: Toggle widget arrow when widget is open/closed.

props MikeHansenMe.
fixes #26748.

#5 in reply to: ↑ 3 @ocean90
6 years ago

  • Keywords needs-testing removed
  • Milestone changed from Awaiting Review to 4.0

Replying to shaunandrews:
Can you please open a new ticket for your enhancement?

Note: See TracTickets for help on using tickets.