Fix and improve the comment moderation keyboard shortcuts

[azaozz]

The shortcuts for approve (a), spam (s), bulk approve (shift+a) and bulk spam (shift+s) are too close together (on qwerty keyboards). That can result in mistyping them.

The toggle-checkboxes shortcut (shift+x) doesn't work.

If the user clicks a checkbox, all shortcuts stop working until the user clicks somewhere else.

[azaozz]

In 26889:

Comment moderation shortcuts:

• Fix "toggle checkboxes" (shift+x).
• Add noDisable selector and use it to stop disabling the shortcuts when a select-comment checkbox is focused.

See #26755.

[nacin]

I don't think we should change the shortcuts — is that what this ticket is proposing?

[azaozz]

Yeah, wondering about that too. Currently they match the first letter of the action: A = approve, S = spam, which seems best. On the other hand setting 50 comments to approved (shift+a) instead of spam by mistake is not good either...

[bcworkz]

Yes, the spam key is disturbingly close to approve. The most ergonomic key for spam, given the present assignments, is 'V'. I can't think of a good mnemonic for V for spam though.

While the shift-X doesn't work, it's not a big deal since just X toggles the checkbox as well. What would be nice instead of both keys doing the same thing is have the shift-X include an "auto-J" where the focus is moved down to the next comment after toggling the checkbox.

In a similar vein, an auto-J would be useful with the A key as well, though shift-A is already spoken for, so I'm unsure how to handle that one. All I know is auto-J would be useful for both X and A.

(For anyone following along who doesn't use keyboard shortcuts, the spam and delete keys already in effect have an auto-J function because the current comment is taken out of the main list, moving the focus down to the next comment.)

[chriscct7]

Change the key shortcuts requires user experience review

[helen]

I think we're probably pretty well stuck with the keyboard shortcuts at this point - can we spin things that are actually broken out into a separate ticket, if they're still broken?

[chriscct7]

Yeah I think the only thing left on this ticket was a remap of spam and accept because of the key placement, so as such, closing as wontfix.