WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#26756 closed enhancement (wontfix)

Vertical align dashboard "At a Glance" post(count) links

Reported by: corvannoorloos Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.8
Component: Administration Keywords: has-patch
Focuses: ui Cc:

Description

Hello,

As the list elements of the dashboard "At a Glance" meta box are higher than its link elements, would it be possible to have them vertically (middle) aligned?

Attachments (4)

patch-02-01-2013.patch (762 bytes) - added by corvannoorloos 6 years ago.
before.png (5.6 KB) - added by corvannoorloos 6 years ago.
after.png (5.6 KB) - added by corvannoorloos 6 years ago.
26756.patch (477 bytes) - added by ocean90 6 years ago.

Download all attachments as: .zip

Change History (12)

#1 @ocean90
6 years ago

  • Keywords has-patch ui-focus added
  • Version changed from trunk to 3.8

Can you please provide a before/after screenshot?

@corvannoorloos
6 years ago

@corvannoorloos
6 years ago

#2 @corvannoorloos
6 years ago

(For these screenshots only) I've given the link and list elements a different background color to create a better visual.

An alternative method would be to change the position of the icons (top/margin-top) or by giving the link elements a different lineheight.

Because vertical-align: middle; is somewhat relative to size/height I've opted for this solution.

#3 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 3.9

@ocean90
6 years ago

#4 follow-ups: @ocean90
6 years ago

26756.patch is a refresh of patch-02-01-2013.patch.

But I get other results in Chrome, see screenshots:
Before: https://cloudup.com/iaNNYRtV6uk
After: https://cloudup.com/iFgNB3oalZN

The height of the Dashicon is 20px and the line height of the link is 18.200000762939453px.
So do we really need the pixel perfection here?

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.


6 years ago

#6 in reply to: ↑ 4 @helen
6 years ago

Replying to ocean90:

So do we really need the pixel perfection here?

Well, I was going to say go for it, but maybe not. I can't say that it genuinely bothers me, and given browser behavior with rounding, there are no promises, anyway.

#7 in reply to: ↑ 4 @corvannoorloos
6 years ago

Replying to ocean90:

I see what you mean. I believe I had, but now I can't recall if I've tested in both Firefox, Chrome and others.
I am a firm believer in having things pixel perfect however.

I understand if this ticket will be marked as "wont fix", but if I had to choose I'd rather have the link element aligned to the bottom instead of to the top.

Last edited 6 years ago by corvannoorloos (previous) (diff)

#8 @ocean90
6 years ago

  • Milestone 3.9 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Played a bit more with it and couldn't come up with a solution which works in *all* browsers (without using fix heights).

Closing as wontfix for now. If someone has a better approach and patch, feel free to re-open.

Note: See TracTickets for help on using tickets.