Edit Tags form on submission does not stay at the same page and gets redirected

[chiragswadia]

Whenever a category / tag is updated ( name / slug / description ), It gets redirected to the tags list ( i.e. edit-tags.php page ).

This is quite annoying and for re-checking the value updated, We have to search the tag in the list and then confirm our value updated.

The MAJOR problem arises when we have custom category/tag meta in addition to the name, slug and description. To verify whether it is updated or not, It has to be re-opened in edit mode after searching from the list.

I have fixed this issue. After updation a proper message is displayed and the redirect to the tags/categories list is prevented.

[chiragswadia]

Patch for the enhancement/bug

[UmeshSingla]

Added Message array and code to display message

[UmeshSingla]

Checks for referer instead of original referer for 'edittag' case

[UmeshSingla]

I face the same issue, as quite often site requires an additional field for Category, Taxonomy, Tags, and in case of editing terms the form redirects from edit page to Listing page which is incorrect as per the normal UI behaviour, instead the form should redirect to same page.

In edit-tags.php, instead of using wp_get_original_referer, it should be wp_get_referer for the case edittag.

Also various message terms need to be added to edit-tag-form.php.

[UmeshSingla]

Any updates over it?

[SergeyBiryukov]

Has been this way since 0.71.

[UmeshSingla]

Replying to SergeyBiryukov:

Has been this way since 0.71.

I think the current behaviour needs a change, will be great if I can have your reviews here or some other developer feedback.

It is the expected behaviour that if I'm saving any form, it redirects to itself, displaying the changes made to it(even WordPress follows it everywhere), then why exception here?

[rhyswynne]

Patch tested and works as expected (Google Chrome on Windows).

Do suggest that if we go down this route that some sort of notification is presented if we change the UX on this. Checked other functionality (such as Edit Post, Edit Pages etc.) and these are all working when you save they don't return to main page.

[nacin]

I agree this should change. What I'd like to consider is a back button of some sort. For example, when you edit a user, you get a "Back to Users" link.

This has been this way forever; let's see if we can clean up these patches, merge them into one, and ship it in 4.0.

[UmeshSingla]

Agree with your suggestion, but I guess after targetting it to a future release, It is never gonna make it. Happens with many of the tickets.

Still thanks for considering. :)

[samuelsidler]

@UmeshSingla: Definitely work up a merged patch and clean things up as @nacin recommends. We could get this early in the 4.0-cycle if it's ready.

[chiragswadia]

@nacin Its good to see that this will change in the near future, If not 3.9 then 4.0 maybe. And yes what you said about "Go Back" button is definitely required. I have combined the above patch and added the go back link.

[chiragswadia]

Added "Go back" link

[chiragswadia]

Any updates on this ? I guess this was to be added in early 4.0 release.

[ocean90]

Hello chiragswadia, thanks for the patch. Some things you should try to fix:

• "Go Back" can't be translated. Take a look at tags/3.9/src/wp-admin/user-edit.php#L204​ to see how it works. You should also use the same string to be consistent. Not sure what we can use instead of "Users" here, any idea?. Move the string also to the next line, same as on user-edit.php
• The back link should be escaped via esc_url().
• "Go back" will not respect the last page where I was, for example I was on page 2, but the back link is always to the first page. Take a look at tags/3.9/src/wp-admin/includes/class-wp-users-list-table.php#L354​ for inspiration.

[helen]

Needs a new patch per ocean90's comment in the next couple of days or will be punted from 4.0.

[rhyswynne]

Part patch (fixes some of comment 18)

[rhyswynne]

Reverts "Go To Tags" back to "Go Back" on 26758-040714.patch

[rhyswynne]

Added an esc_url() around $original_referrer_url and made "Go Back" Translatable.

Struggled a bit with the third issue ocean90 suggested, but added an if statement should $original_referrer_url be not present (i.e. URL accessed directly), the link will not be placed.

[DrewAPicture]

There seems to be a consensus on wanting this change, though it doesn't seem like there's a consensus on the best way to go about it. I'd caution us against saddling ourselves with a whole new set of messaging arrays without careful consideration of future maintenance. Suggest punt.

[chiragswadia]

Replying to DrewAPicture:

There seems to be a consensus on wanting this change, though it doesn't seem like there's a consensus on the best way to go about it. I'd caution us against saddling ourselves with a whole new set of messaging arrays without careful consideration of future maintenance. Suggest punt.

What you are saying is absolutely correct that having the same message arrays at multiple pages will cause maintenance problems if you consider future releases.

But we cannot rule out the need for this functionality as it`s important in terms of accessibility and user experience.

[ocean90]

Patch needs a whitespace/braces check. We're also in beta already. Punt.

[afercia]

Would be nice to give new life to this ticket. I'm trying :) Refreshed patch:

• uses wp_reset_vars() as done in user-edit.php, not sure about this
• tries to manage the case when a term is created via AJAX
• "Back" link rebuilt to be consistent with "Back to Users" link, uses $tax->labels->name

[SergeyBiryukov]

#32780 was marked as a duplicate.

[afercia]

Refreshed patch. Added the referer parameter to the row-actions "Edit" link. There's a bit of repetition in the code, might need some cleaning. Visually, the "Back" link would look like this:

And for custom taxonomies:

That's similar to the "Back" link in the Edit User screen:

From a UI perspective, I'm not sure having the link in a new line looks so nice, open to suggestions.

[lionhurt]

This is Very annoying, i am happy to know there is others has same feel

is there any Estimated time to add this patch to the core

[wonderboymusic]

[34202]