WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 15 months ago

#26769 reopened enhancement

Change "Your Profile" under Users Menu to "My Profile"

Reported by: akhileshsabharwal Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.8
Component: Text Changes Keywords: needs-patch
Focuses: administration Cc:
PR Number:

Description (last modified by SergeyBiryukov)

Possibly a more friendlier way of writing it, It would also be in line with how a lot of other sites (Facebook, Twitter etc. ) also refer to a users own profile settings, and thus make it more familiar for new users.

It would also match the text that is used in the profile drop down in the Admin Bar which reads : Edit My Profile.

Attachments (4)

26769.patch (834 bytes) - added by bcworkz 6 years ago.
26769.patch.diff (1.4 KB) - added by seanchayes 6 years ago.
26769.one-word.patch (828 bytes) - added by bcworkz 6 years ago.
Version using one word label
26769.4.patch (4.7 KB) - added by mikeschroder 6 years ago.
Includes help text and inline docs changes WRT 'Profile'

Download all attachments as: .zip

Change History (42)

#1 @akhileshsabharwal
6 years ago

  • Summary changed from Change "Your Profile" under Users to "My Profile" to Change "Your Profile" under Users Menu to "My Profile"

#2 @SergeyBiryukov
6 years ago

  • Description modified (diff)
  • Keywords ux-feedback added
  • Milestone changed from Awaiting Review to 3.9

Being consistent with the link in the Toolbar makes sense to me.

@bcworkz
6 years ago

#3 @bcworkz
6 years ago

  • Keywords has-patch added

Sure, why not? I personally always thought the "My Computer" et.al. was too cute, but it's become ubiquitous. It does promote a friendlier, more accessible feeling.

#4 @ScottSmith
6 years ago

I like this. It sounds much friendlier and we already have translations for it too.

#5 @seanchayes
6 years ago

I tested the patch and it worked as expected.

One suggestion might be (in the attached 26769.patch.diff) to also rename the top menu "Profile" to "My Profile".

if ( current_user_can('list_users') )
	$menu[70] = array( __('Users'), 'list_users', 'users.php', '', 'menu-top menu-icon-users', 'menu-users', 'none' );
else
	$menu[70] = array( __('My Profile'), 'read', 'profile.php', '', 'menu-top menu-icon-users', 'menu-users', 'none' );

#6 @nacin
6 years ago

  • Keywords commit added

Sounds sensible overall. I would keep just Profile at the top level, though. One word names are good, and we've also consciously avoided the first submenu from matching the name of the top level menu.

Asking jenmylo to weigh in, then we can commit.

#7 @jenmylo
6 years ago

+1 to consistency, +1 to one-word labels like Profile instead of [My/Your] Profile. In terms of consistency, please take wordpress.org profiles/forum profiles into account. We should make it consistent across all of them (which it was when all the links said your profile). We did make a decision to use your instead of my a long time back, not sure when admin bar got edit my profile on it, must have missed the inconsistency at that time.

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.


6 years ago

@bcworkz
6 years ago

Version using one word label

#9 @bcworkz
6 years ago

Ooo! I like the one word version. I noted my personal reservation of using "My" previously, this fixes it for me.

@mikeschroder
6 years ago

Includes help text and inline docs changes WRT 'Profile'

#10 @mikeschroder
6 years ago

Updated patch to include inline docs and help changes to reflect the change to 'Profile'.

Unsure about the first change in src/wp-admin/about.php -- 'visit your profile' was changed to 'update your profile' to avoid directly referencing the name of the screen, but still matching sentence structure.

The other option would be to change it to something like 'visit the Profile screen'.

This ticket was mentioned in IRC in #wordpress-dev by DH-Shredder. View the logs.


6 years ago

#12 @mikeschroder
6 years ago

  • Focuses administration added
  • Keywords needs-patch added; ux-feedback has-patch commit removed

Chatted about this with @nacin in the session marked above.

We'll also want to handle the "My" sections in the admin bar at the same time, which is not included in the last patch I posted.

#13 @mikeschroder
6 years ago

  • Milestone changed from 3.9 to Future Release

While I still like the simplification, since it sounds from chat like there isn't currently consensus as to whether we really want to do this, and the "My"s are fairly ingrained code-wise, pushing this from 3.9.

#14 @akhileshsabharwal
5 years ago

As the person who opened this ticket, I would like to help further in trying to help make / not make the decision to make the change in the menu items. As per IRC tickets, there was a suggestion to do a review of popular sites and to try and see how the My vs Your is being used in terms of profiles. But it was also something that I understood, was requested from the UX teams.

But - I would like to help doing that, gathering and evaluating that input. Can I?

This ticket was mentioned in Slack in #core by ocean90. View the logs.


5 years ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


5 years ago

#17 @jorbin
5 years ago

#31110 was marked as a duplicate.

#18 @afercia
5 years ago

One more place for "my" vs. "your" would be the "Logged in as {display name}" link in the comments form. In #29974 we're reviewing accessibility details for the comments form and we'd like to add some aria-label to that link, something like

aria-label="Edit your profile/Edit My Profile"

Please :) we really need a feedback. Hope this ticket will get some more traction soon.

#19 @swissspidy
4 years ago

  • Focuses accessibility added
  • Keywords good-first-bug ux-feedback added

There isn't currently consensus as to whether we really want to do this, and the "My"s are fairly ingrained code-wise.

Personally I'm +1 on it, but some UX feedback would be great I think.

As per IRC tickets, there was a suggestion to do a review of popular sites and to try and see how the My vs Your is being used in terms of profiles. But it was also something that I understood, was requested from the UX teams.

Anyone got time to do that?

#20 follow-up: @Felix Edelmann
4 years ago

I've started with some most popular websites:

(ordered by amount of users)

PGoogle Plus
PFacebook
PWhatsApp
MTwitter
YAmazon
PInstagram
MHabbo
PLinkedIn
PeBay¹
MPinterest
PStack Overflow
YFlickr
MWordpress.com


M => My profile 4/13 (31%)
Y => Your profile 2/13 (15%)
P => Profile 7/13 (54%)

¹ There's a section called "My ebay", but that's a kind of hub for personal notifications. The page "Account" is without any possessive pronoun.

Edit 1 (2015-12-27 11:43 CET):

  • Added WordPress.com according to @swissspidy
  • Added Summary

Edit 2 (2016-01-05 22:28 CET):

  • Added Amazon and eBay
Last edited 4 years ago by Felix Edelmann (previous) (diff)

#21 in reply to: ↑ 20 @swissspidy
4 years ago

Replying to Felix Edelmann:

I've started with some most popular websites:

M => My profile
Y => Your profile
P => Profile

(ordered by amount of users)

PGoogle Plus
PFacebook
PWhatsApp
MTwitter
PInstagram
MHabbo
PLinkedIn
MPinterest
PStack Overflow
YFlickr

WordPress.com uses "My profile" as well.

#22 @Felix Edelmann
4 years ago

Just added Amazon and eBay (see #comment:20, I edit it). Seems like "Profile" is winning with 54% against 31% (My) and 15% (Your).

#23 @DrewAPicture
3 years ago

@mikeschroder Any chance you'd like to follow up on this?

#24 @mikeschroder
3 years ago

I don't have strong opinions either way, but am happy to facilitate.

@helen @melchoyce, any opinions here?

#25 follow-up: @helen
3 years ago

I actually have always found "Profile" to be misleading in WordPress; to me a profile is the thing other people see, and I believe that is the actual content of most (if not all) of the sites that are being cited above. In our case it's editing your profile (which may or may not actually show anywhere on a given site) along with settings/personal preferences/whatever you want to call them.

P.S. I think that mix of profile fields and preferences is also weird.

P.P.S. Sorry in advance for the rabbit hole(s).

#26 in reply to: ↑ 25 ; follow-up: @mikeschroder
3 years ago

Replying to helen:

I actually have always found "Profile" to be misleading in WordPress; to me a profile is the thing other people see, and I believe that is the actual content of most (if not all) of the sites that are being cited above <snip>
P.P.S. Sorry in advance for the rabbit hole(s).

I agree, this is not best for users, and would be great to investigate a way to fix it!
I think that's beyond the scope of this ticket as it stands, though.

Outside of that, do you think we should s/Your Profile/Profile/?

#27 @alexndev
3 years ago

Surely the solution falls to a mixture of both UX and ease of implementation. You have to weigh up development effort against business worth and in this case, My Profile is already listed in the admin bar..

From a UX perspective from the users chair, reading "Your Profile" is TELLING the user something, saying "My Profile" is guiding them towards something.

In my experience I've often found that something as simple as wording an item in this manner can make all the difference. Even if it is so subtle that it could be easily overlooked.

The overall build quality of a car is what brings buyers to the car yard.. but its the nice feel and supple leather that turns a looker into a buyer.

Niceties...

#28 in reply to: ↑ 26 @helen
3 years ago

Replying to mikeschroder:

Outside of that, do you think we should s/Your Profile/Profile/?

My inclination is to change the admin menu item to read "Edit My Profile". Just "Profile" is still misleading and I don't really see a point in changing from one misleading thing to another. As for the other changes in the last old patch, wp-mce-help.php does not appear to be a thing anymore, and the rest of the changes from "Your Profile" to "Profile" in help text would be accurate anyway, because the screen's title is just "Profile".

#29 @melchoyce
3 years ago

I'm a +1 for cutting you/my entirely and just going with "Profile." (Though I agree that calling it a "profile" in general isn't super accurate.)

#30 @Jastuccio
3 years ago

  • Keywords good-first-bug removed

#31 @Jastuccio
3 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Removed the "good first bug" tag. There does not seem to be consensus on this issue.

#32 follow-up: @SergeyBiryukov
3 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#33 in reply to: ↑ 32 @Jastuccio
3 years ago

Replying to SergeyBiryukov: Thank Sergey. I only meant to remove the good first bug tag. Closing the ticket was an accident.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 years ago

#35 @afercia
3 years ago

  • Focuses accessibility removed

Removing the accessibility focus just to take this ticket out from the a11y report, will follow anyways.

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


2 years ago

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


15 months ago

#38 @karmatosed
15 months ago

  • Keywords ux-feedback removed

Profile works the best here, lets remove the ux-feedback as there is some for this.

Note: See TracTickets for help on using tickets.