WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#26783 closed defect (bug) (fixed)

Wrong behavior of the deletion link in the Media Library window when MEDIA_TRASH is set to 'true'

Reported by: toszcze Owned by: wonderboymusic
Priority: normal Milestone: 3.9
Component: Media Version: 3.9
Severity: normal Keywords: has-patch
Cc: Focuses: javascript

Description

When the trash for attachments is enabled (MEDIA_TRASH constant is set to 'true'), the link for deleting the attachment in the Media Library window still says 'Delete Permanently' instead of 'Trash'. Also clicking this link displays an incorrect confirmation message.

Attachments (2)

media_trash_delete.png​ (43.6 KB ) - added by toszcze 13 years ago.
26783.diff​ (3.1 KB ) - added by toszcze 13 years ago.

Download all attachments as: .zip

Change History (6)

@toszcze
13 years ago

@toszcze
13 years ago

#1 @toszcze
13 years ago

  • Keywords has-patch added

#2 @wonderboymusic
13 years ago

  • Milestone Awaiting Review → 3.9

Sounds like a good idea.

#3 @wonderboymusic
13 years ago

  • Focuses javascript added

#4 @wonderboymusic
13 years ago

  • Owner set to wonderboymusic
  • Resolution → fixed
  • Status new → closed

In 27454:

When MEDIA_TRASH is true, show the proper context in the attachment-details sidebar. Without this fix, it always showed "Delete Permanently."

Props toszcze.
Fixes #26783.

Note: See TracTickets for help on using tickets.