Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#26793 closed defect (bug) (fixed)

Revisions display incorrect after switching to two handled mode, then back to single handled mode

Reported by: adamsilverstein's profile adamsilverstein Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.8
Component: Revisions Keywords: has-patch dev-feedback
Focuses: javascript Cc:

Description

To reproduce this bug:

  • Create a post with several revisions
  • Switch to two handled mode, drag the 'from' (left) handle to change the from comparison
  • Switch back to single handle mode - the display is stuck on the two handle comparison, the from position should be changed to the revision previous to the to position, but it is not
  • hitting reload without changing anything the display changes, it should not

Here is a screen recording demonstrating the issue: http://cl.ly/0Z1J1W2g2s3n

Attachments (1)

26793.diff (1.1 KB) - added by adamsilverstein 12 years ago.
explicitly set from handle when switching back to single handled mode

Download all attachments as: .zip

Change History (9)

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.


12 years ago

@adamsilverstein
12 years ago

explicitly set from handle when switching back to single handled mode

#2 @adamsilverstein
12 years ago

  • Focuses javascript added
  • Keywords has-patch dev-feedback added

in 26793.diff - reset the from model to one before the to model when switching back two handled mode to single handled mode.

#3 follow-up: @nacin
12 years ago

26793.diff looks good to me at a glance. Good to go?

#4 in reply to: ↑ 3 @adamsilverstein
12 years ago

Replying to nacin:

26793.diff looks good to me at a glance. Good to go?

I think its fine and I tested it, I would still appreciate any additional review and testing.

This ticket was mentioned in IRC in #wordpress-dev by adamsilverstein. View the logs.


12 years ago

This ticket was mentioned in IRC in #wordpress-dev by adamsilverstein. View the logs.


12 years ago

#7 @SergeyBiryukov
12 years ago

  • Milestone changed from Awaiting Review to 4.0

#8 @SergeyBiryukov
12 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29052:

Revisions: Explicitly set the 'from' handle position when switching from two-handled mode back to single-handled mode.

props adamsilverstein.
fixes #26793.

Note: See TracTickets for help on using tickets.