Navigation Menu does not updates after a page or post is deleted, which leads to inconsistent menu in backend and frontend

[UmeshSingla]

If I've added a page in menu and later I delete it permanently, It does not get remove from menu items and instead displays notice as $original_object = get_post( $menu_item->object_id ); in nav_menu.php on line 596 returns nothing.
Theme: Twentyfourteen
Wordpress Version 3.8

To replicate the issue:

1. Create a Normal Page.
2. Add page to menu and Update it.
3. Delete the Page Permanently
4. If debug is turned, php notice are there on the menu page in backend as well as frontend. If debug is off you can still see the space for items in menu.
5. On saving the menu back, the menu item is removed.

It happens as _wp_delete_post_menu_item is not updating the menu items on delete_post hook

[UmeshSingla]

Space for deleted pages in backend still appears.

[UmeshSingla]

Notice on frontend menu, as the page is deleted and menu items are not yet updated.

[UmeshSingla]

Notices in backend

[nacin]

Dropping a comment on this ticket as the new ticket notification accidentally did not go out.

[UmeshSingla]

Solves the issue for me

[UmeshSingla]

is it going to be reviewed at all?

[markoheijnen]

I just looked at your patch to leave my first comment. I have experienced this issue before but never looked into it.

The removed code I don't know yet if that is needed but I do believe that this doesn't solve the whole problem. The problem to me is that the menu item isn't removed and I would expect that would be the case. To me that should be addressed too.

I'm curious if we should show an indication that a page/post is in a menu. Also I do want to mention that 3 days is a short period. Sometimes it takes a bit longer that someone has the time to look into it.

[UmeshSingla]

Updated the condition to check item type

[UmeshSingla]

@markoheijnen The above patch only fixes the issue when you are permanently deleting a page and not if you just trash it.

It works absolutely fine for me, does it not fixes the issue for you if you permanently delete (and not trash) a page or post?

[ocean90]

The issue is, that _wp_delete_post_menu_item() doesn't delete the nav menu object. _wp_delete_post_menu_item() is hooked into delete_post.

[UmeshSingla]

Update menu items on wp_trash_post filter

[ocean90]

Haven't seen 26795.nav-menu.php.patch​ which works for me after a quick test.

The unit test test_wp_get_associated_nav_menu_items() should be extend for post types.

[UmeshSingla]

It'll require both the changes filter wp_trash_post and changes in wp_get_associated_nav_menu_items

[ocean90]

The menu item shouldn't be removed if a post is trashed, see #13822.

[UmeshSingla]

I just checked the ticket, there is a long debate to not remove items from menu if post/page is trashed.
So we could just go with the patch 26795.nav-menu.php.patch if it goes good with with the testing.

[ocean90]

26795.patch​ should fix this. _menu_item_object is not relevant for post types.

[ocean90]

Broken since [25163].

[ocean90]

There is no need for these focuses.

[nacin]

Replying to ocean90:

26795.patch​ should fix this. _menu_item_object is not relevant for post types.

If that's right, this patch looks good to me.

[ocean90]

In 27150:

Nav Menu: Remove post/page items from the Nav Menu when the post/page is deleted.

This was broken through a change in [25163]. _menu_item_object in wp_get_associated_nav_menu_items() is not relevant for post types.
Adds unit tests.

props UmeshSingla for initial patch.
fixes #26795.