Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#26796 closed enhancement (fixed)

Replace post lock icon with a dashicon

Reported by: melchoyce's profile melchoyce Owned by: nacin's profile nacin
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Posts, Post Types Keywords: has-patch
Focuses: ui, administration Cc:

Description

The post lock icon is still using old, pre-3.8 styles:
https://i.cloudup.com/qThQRxvFN9.png

Let's replace it with .dashicons-lock .

Attachments (2)

26796.diff (1.5 KB) - added by melchoyce 11 years ago.
26796.2.diff (1.7 KB) - added by kirasong 11 years ago.
Refreshed after CSS splitting funtimes

Download all attachments as: .zip

Change History (9)

#1 @ocean90
11 years ago

  • Keywords ui-focus added
  • Milestone changed from Awaiting Review to 3.9

#2 @nacin
11 years ago

Dropping a comment on this ticket as the new ticket notification accidentally did not go out.

@melchoyce
11 years ago

#3 @melchoyce
11 years ago

  • Keywords has-patch added

26796.diff​ removes the lock icon from wp-admin.css and replaces it with the lock dashicon, then makes it a lighter color in colors.css.

#4 @nacin
11 years ago

  • Component changed from Administration to Posts, Post Types
  • Focuses administration added

@kirasong
11 years ago

Refreshed after CSS splitting funtimes

#5 @kirasong
11 years ago

Refreshed after wp-admin.css and colors.css splitting/merging.
The patch applies to src/.

Two things:

  • Unsure if edit.css is the right place for the color rule. Seems like it may belong in list-tables.css(?), since the icon isn't used in the edit screen, but I put it there because it matched up with previous patch placement pre-split.
  • Removed the@print section from list-tables.css because the patch removes the last rule. If this was incorrect, or it should be left for organization's sake, it can certainly be added back.

Edit:
We'll also want to remember remove wp-admin/images/[lock.png|lock-2x.png]

Last edited 11 years ago by kirasong (previous) (diff)

#6 @nacin
11 years ago

  • We can consolidate this in list-tables.css.
  • Agreed with removing @media rule.

#7 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27392:

Convert the post lock icon to a dashicon.

props melchoyce, DH-Shredder.
fixes #26796.

Note: See TracTickets for help on using tickets.