WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#26797 closed enhancement (duplicate)

Replace in-post image editing icons with dashicons

Reported by: melchoyce Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.8
Component: Editor Keywords:
Focuses: ui Cc:

Description

When you add an image into a post's visual editor, you still get pre-3.8 style icons:
https://i.cloudup.com/QVn950AzyO.png

Let's replace these with dashicons. This is what I'm thinking:

  1. Edit image
  • We could just use .dashicons-format-image to replace this icon, but I think it makes more sense to use something more along the lines of .dashicons-admin-generic, which is the cog icon. When it comes down to it, the "image" icon doesn't really tell you what clicking on it will do — that is, bring up an image settings panel which will allow you to edit various image attributes, positioning, and size. To me, that kind of panels says "settings," which is why I think the cog might be a more relevant icon to use.
  1. Remove image
  • In this case, I think we should definitely replace the current icon, which uses the prohibition symbol, with .dashicons-no or .dashicons-no-alt, which are our two X icons. The prohibition symbol is generally used to convey "not allowed", while an X conveys "remove" or "get rid of this, but don't delete it." I think it's a more accurate icon to use. Additionally, the prohibition icon is not a completely international symbol — there are several countries and cultures for which this symbol has no meaning. The X might be a more universal symbol.

Any thoughts before I make a patch?

Change History (9)

#1 @melchoyce
7 years ago

  • Keywords ui-focus added

#3 @melchoyce
7 years ago

I just went to work on a patch for this but I'm seeing changes to TinyMCE:

https://cloudup.com/inzQZMQ3h2a
https://cloudup.com/ce5qcXuBthi

I'm guessing this is somehow related to #24067 / TinyMCE 4.0?

This ticket was mentioned in IRC in #wordpress-dev by melchoyce. View the logs.


7 years ago

This ticket was mentioned in IRC in #wordpress-ui by melchoyce. View the logs.


7 years ago

This ticket was mentioned in IRC in #wordpress-ui by melchoyce. View the logs.


7 years ago

#7 @SergeyBiryukov
7 years ago

  • Version changed from trunk to 3.8

#8 @SergeyBiryukov
7 years ago

  • Component changed from Administration to Editor

#9 @melchoyce
7 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

I'm closing this as a repeat of #27320.

Note: See TracTickets for help on using tickets.