Error on Inline Uploading after deleting page with attached file

[ryanscheuermann]

OK, here's how to replicate:

1) Create a page with test content
2) Publish the page
3) Edit the page
3) Upload an image in the inline iframe when on the edit screen for that page
4) Click Manage->Pages
5) Delete the page
6) Click Write->Write Page
7) In the inline uploading iframe, click Browse All
8) You should see this error:

Warning: strtotime() [function.strtotime]: Called with an empty time parameter. in wp-includes\template-functions-links.php on line 53

Warning: date() [function.date]: Windows does not support dates prior to midnight (00:00:00), January 1, 1970 in wp-includes\template-functions-links.php on line 65

The get_attachment_link function is trying to use a parent post that doesn't exist. (template_function_links.php - around line 117)

SOLUTION: We should intentionally be orphaning attachments (update post_parent to 0) when deleting pages/posts. Otherwise, we just have bad data.

I'll submit a patch in a minute...

[ryanscheuermann]

orphan attachments after deleting post (update post_parent = 0)

[ryanscheuermann]

Patch update: when deleting posts, parent_post should inherit attachments

[markjaquith]

Confirmed still an issue.

This solution seems right to me. 2nd opinion?

[markjaquith]

(In [4601]) change post_parent on orphaned attachments. props ryanscheuermann. fixes #2681

[markjaquith]

(In [4602]) change post_parent on orphaned attachments. props ryanscheuermann. fixes #2681