WordPress.org

Make WordPress Core

Opened 16 years ago

Closed 15 years ago

Last modified 15 years ago

#2681 closed defect (bug) (fixed)

Error on Inline Uploading after deleting page with attached file

Reported by: ryanscheuermann Owned by: ryanscheuermann
Milestone: 2.0.6 Priority: normal
Severity: normal Version: 2.1
Component: Administration Keywords: upload, attachment links, bg|has-patch, bg|dev-feedback
Focuses: Cc:

Description

OK, here's how to replicate:

1) Create a page with test content
2) Publish the page
3) Edit the page
3) Upload an image in the inline iframe when on the edit screen for that page
4) Click Manage->Pages
5) Delete the page
6) Click Write->Write Page
7) In the inline uploading iframe, click Browse All
8) You should see this error:

Warning: strtotime() [function.strtotime]: Called with an empty time parameter. in wp-includes\template-functions-links.php on line 53

Warning: date() [function.date]: Windows does not support dates prior to midnight (00:00:00), January 1, 1970 in wp-includes\template-functions-links.php on line 65

The get_attachment_link function is trying to use a parent post that doesn't exist. (template_function_links.php - around line 117)

SOLUTION: We should intentionally be orphaning attachments (update post_parent to 0) when deleting pages/posts. Otherwise, we just have bad data.

I'll submit a patch in a minute...

Attachments (2)

orphan_attachments.patch (624 bytes) - added by ryanscheuermann 16 years ago.
orphan attachments after deleting post (update post_parent = 0)
orphan_attachments2.patch (677 bytes) - added by ryanscheuermann 16 years ago.
Patch update: when deleting posts, parent_post should inherit attachments

Download all attachments as: .zip

Change History (7)

@ryanscheuermann
16 years ago

orphan attachments after deleting post (update post_parent = 0)

@ryanscheuermann
16 years ago

Patch update: when deleting posts, parent_post should inherit attachments

#1 @ryanscheuermann
16 years ago

  • Keywords bg|has-patch bg|dev-feedback added
  • Owner changed from anonymous to ryanscheuermann
  • Status changed from new to assigned

#2 @markjaquith
15 years ago

Confirmed still an issue.

This solution seems right to me. 2nd opinion?

#3 @markjaquith
15 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4601]) change post_parent on orphaned attachments. props ryanscheuermann. fixes #2681

#4 @markjaquith
15 years ago

(In [4602]) change post_parent on orphaned attachments. props ryanscheuermann. fixes #2681

#5 @markjaquith
15 years ago

  • Milestone changed from 2.1 to 2.0.6
Note: See TracTickets for help on using tickets.