WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#26811 closed defect (bug) (fixed)

Bundled Themes: Use `display` context for `get_bloginfo()` in `wp_title` filter

Reported by: michelwppi Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch commit fixed-major
Focuses: Cc:
PR Number:

Description

as developer of xili-language multilingual plugin, after a support enquiry, I discover that wp_filter (twentythirteen_wp_title function) inside functions.php of 2013 show a issue:

to display blogname you forgot to add second parameter 'display' in

get_bloginfo ('name');

as done in wp_title for description ( see #25808 )...

get_bloginfo ('name', 'display');

By using this parameter, get_bloginfo is filterable (apply_filters at end of function get_bloginfo ) as wp_title used in header...
I think it will be coherent to be done in parent 2013 and not with a remove filter in child theme and add a new fixed filter...

Happy new year

M.

Attachments (1)

26811.patch (1.6 KB) - added by SergeyBiryukov 6 years ago.

Download all attachments as: .zip

Change History (6)

#1 @SergeyBiryukov
6 years ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 3.9
  • Summary changed from twentythirteen : unperfect wp_title filter in functions.php to Twenty Thirteen: Use 'display' context for get_bloginfo() in wp_title filter

Makes sense. Let's do the same for all the default themes that use wp_title filter.

#2 @lancewillett
6 years ago

  • Milestone changed from 3.9 to 3.8.2
  • Summary changed from Twenty Thirteen: Use 'display' context for get_bloginfo() in wp_title filter to Bundled Themes: Use `display` context for `get_bloginfo()` in `wp_title` filter

#3 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27091:

Default themes: Use the 'display' filter for get_bloginfo( 'name' ) attached to the wp_title filter.

props michelwppi.
fixes #26811.

#4 @nacin
6 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#5 @nacin
6 years ago

  • Milestone changed from 3.8.2 to 3.9
  • Resolution set to fixed
  • Status changed from reopened to closed

lancewillett and I decided that we would be leaving all bundled theme tickets for 3.9. Given the timeline (and lack of severity) we won't be doing a theme update before then.

Note: See TracTickets for help on using tickets.