Opened 13 years ago
Closed 12 years ago
#26843 closed enhancement (fixed)
Let jQuery UI 1.11 handle touch-action compatibility for IE Touch
| Reported by: | georgestephanis | Owned by: | ocean90 |
|---|---|---|---|
| Priority: | low | Milestone: | 4.1 |
| Component: | External Libraries | Version: | 3.9 |
| Severity: | normal | Keywords: | has-patch needs-testing |
| Cc: | Focuses: |
Description
Support will be getting pulled in upstream via https://github.com/jquery/jquery-ui/pull/1152
Once that goes and we update our internal versions to catch it, we can safely drop our ms-touch-action and touch-action CSS overrides, as per the attached patch.
Attachments (3)
Change History (17)
#2
@
13 years ago
- Milestone Awaiting Review → 3.9
georgestephanis, do we have to update our jQuery UI CSS files now? Asking because your patch removes the lines, but the commit adds them.
#3
@
13 years ago
Yes, we'd need to ship the new jquery.ui.draggable.css and jquery.ui.sortable.css files, as well as the additions to jquery.ui.slider.css, jquery.ui.resizeable.css, and jquery.ui.selectable.css -- this ticket was more a reminder to remove our own implementations when the upstream ones get released with v1.11 (which is still pending)
#4
@
13 years ago
- Milestone 3.9 → Future Release
- Summary Let jQuery UI handle touch-action compatibility for IE Touch → Let jQuery UI 1.11 handle touch-action compatibility for IE Touch
I have a ping pending upstream to ascertain the timeline for jQuery 1.11. Since it's a major release, it'd need to land pretty early in beta to get enough testing — I'd say at least a month before core release. Looking more like it'll miss the boat for 3.9. I'm going to punt this; we can bring this ticket back in if 1.11 ends up being released.
This ticket was mentioned in IRC in #wordpress-dev by georgestephanis. View the logs.
12 years ago
#7
@
12 years ago
- Milestone Future Release → 4.1
Okay, let's use this ticket then to update our CSS copies for jQuery UI.
#8
@
12 years ago
- Includes https://github.com/jquery/jquery-ui/blob/master/themes/base/dialog.css
- Includes https://github.com/jquery/jquery-ui/blob/master/themes/base/resizable.css
- Includes https://github.com/jquery/jquery-ui/blob/master/themes/base/sortable.css
- Includes https://github.com/jquery/jquery-ui/blob/master/themes/base/draggable.css
- Includes https://github.com/jquery/jquery-ui/blob/master/themes/base/slider.css#L21-L22
I don't have a device to test IE Touch. georgestephanis, can you please test this?
#12
@
12 years ago
Gah, knew I forgot something. I'm adding myself a reminder in slack to do it tonight when I get home.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
The upstream fixes will ship with jQuery UI v1.11