Make WordPress Core

Opened 13 years ago

Closed 12 years ago

#26843 closed enhancement (fixed)

Let jQuery UI 1.11 handle touch-action compatibility for IE Touch

Reported by: georgestephanis Owned by: ocean90
Priority: low Milestone: 4.1
Component: External Libraries Version: 3.9
Severity: normal Keywords: has-patch needs-testing
Cc: Focuses:

Description

Support will be getting pulled in upstream via https://github.com/jquery/jquery-ui/pull/1152

Once that goes and we update our internal versions to catch it, we can safely drop our ms-touch-action and touch-action CSS overrides, as per the attached patch.

See: #22583, #26297

Attachments (3)

26843.diff (1.4 KB ) - added by georgestephanis 13 years ago.
26843.patch (4.2 KB ) - added by ocean90 12 years ago.
26843.2.patch (4.5 KB ) - added by ocean90 12 years ago.
Includes copyright banner for Draggable/Sortable CSS

Download all attachments as: .zip

Change History (17)

#1 @georgestephanis
13 years ago

The upstream fixes will ship with jQuery UI v1.11

#2 @ocean90
13 years ago

  • Milestone Awaiting Review3.9

georgestephanis, do we have to update our jQuery UI CSS files now? Asking because your patch removes the lines, but the commit adds them.

#3 @georgestephanis
13 years ago

Yes, we'd need to ship the new jquery.ui.draggable.css and jquery.ui.sortable.css files, as well as the additions to jquery.ui.slider.css, jquery.ui.resizeable.css, and jquery.ui.selectable.css -- this ticket was more a reminder to remove our own implementations when the upstream ones get released with v1.11 (which is still pending)

#4 @nacin
13 years ago

  • Milestone 3.9Future Release
  • Summary Let jQuery UI handle touch-action compatibility for IE TouchLet jQuery UI 1.11 handle touch-action compatibility for IE Touch

I have a ping pending upstream to ascertain the timeline for jQuery 1.11. Since it's a major release, it'd need to land pretty early in beta to get enough testing — I'd say at least a month before core release. Looking more like it'll miss the boat for 3.9. I'm going to punt this; we can bring this ticket back in if 1.11 ends up being released.

This ticket was mentioned in IRC in #wordpress-dev by georgestephanis. View the logs.


12 years ago

#6 @georgestephanis
12 years ago

jQuery UI 1.11.1 has landed in core thanks to #29833 [29847] so this should be mergeable now.

#7 @ocean90
12 years ago

  • Milestone Future Release4.1

Okay, let's use this ticket then to update our CSS copies for jQuery UI.

@ocean90
12 years ago

@ocean90
12 years ago

Includes copyright banner for Draggable/Sortable CSS

#9 @ocean90
12 years ago

  • Keywords needs-testing added

#10 @georgestephanis
12 years ago

Yup, will test and confirm later tonight / tomorrow.

#11 @ocean90
12 years ago

@georgestephanis Any news on this?

#12 @georgestephanis
12 years ago

Gah, knew I forgot something. I'm adding myself a reminder in slack to do it tonight when I get home.

#13 @georgestephanis
12 years ago

Just tested and the current patch works beautifully on my SurfaceRT. The dragging is kinda laggy, but it's an underpowered tablet, it happens.

+1 to commit.

#14 @ocean90
12 years ago

  • Owner set to ocean90
  • Resolutionfixed
  • Status newclosed

In 30343:

Sync our jQuery UI styles with jQuery UI 1.11.2 CSS.

Removes also our own implementations for touch-action compatibility for IE Touch.

props georgestephanis, ocean90.
fixes #26843.

Note: See TracTickets for help on using tickets.