Opened 11 years ago
Closed 10 years ago
#26843 closed enhancement (fixed)
Let jQuery UI 1.11 handle touch-action compatibility for IE Touch
Reported by: | georgestephanis | Owned by: | ocean90 |
---|---|---|---|
Milestone: | 4.1 | Priority: | low |
Severity: | normal | Version: | 3.9 |
Component: | External Libraries | Keywords: | has-patch needs-testing |
Focuses: | Cc: |
Description
Support will be getting pulled in upstream via https://github.com/jquery/jquery-ui/pull/1152
Once that goes and we update our internal versions to catch it, we can safely drop our ms-touch-action
and touch-action
CSS overrides, as per the attached patch.
Attachments (3)
Change History (17)
#2
@
11 years ago
- Milestone changed from Awaiting Review to 3.9
georgestephanis, do we have to update our jQuery UI CSS files now? Asking because your patch removes the lines, but the commit adds them.
#3
@
11 years ago
Yes, we'd need to ship the new jquery.ui.draggable.css
and jquery.ui.sortable.css
files, as well as the additions to jquery.ui.slider.css
, jquery.ui.resizeable.css
, and jquery.ui.selectable.css
-- this ticket was more a reminder to remove our own implementations when the upstream ones get released with v1.11 (which is still pending)
#4
@
11 years ago
- Milestone changed from 3.9 to Future Release
- Summary changed from Let jQuery UI handle touch-action compatibility for IE Touch to Let jQuery UI 1.11 handle touch-action compatibility for IE Touch
I have a ping pending upstream to ascertain the timeline for jQuery 1.11. Since it's a major release, it'd need to land pretty early in beta to get enough testing — I'd say at least a month before core release. Looking more like it'll miss the boat for 3.9. I'm going to punt this; we can bring this ticket back in if 1.11 ends up being released.
This ticket was mentioned in IRC in #wordpress-dev by georgestephanis. View the logs.
10 years ago
#7
@
10 years ago
- Milestone changed from Future Release to 4.1
Okay, let's use this ticket then to update our CSS copies for jQuery UI.
#8
@
10 years ago
- Includes https://github.com/jquery/jquery-ui/blob/master/themes/base/dialog.css
- Includes https://github.com/jquery/jquery-ui/blob/master/themes/base/resizable.css
- Includes https://github.com/jquery/jquery-ui/blob/master/themes/base/sortable.css
- Includes https://github.com/jquery/jquery-ui/blob/master/themes/base/draggable.css
- Includes https://github.com/jquery/jquery-ui/blob/master/themes/base/slider.css#L21-L22
I don't have a device to test IE Touch. georgestephanis, can you please test this?
#12
@
10 years ago
Gah, knew I forgot something. I'm adding myself a reminder in slack to do it tonight when I get home.
The upstream fixes will ship with jQuery UI v1.11