WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#26866 closed defect (bug) (fixed)

Twenty Twelve uses class .singular that is not defined in the theme

Reported by: TomasM Owned by: lancewillett
Milestone: 3.9 Priority: low
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

In style.css under @media print we find bunch of rules with the class .singular. As far as I know, Twenty Twelve does not generate such body class.

Most likely easiest way to fix it is to append code from Twenty Fourteen to the function that creates extra BODY classes:

if ( is_singular() && ! is_front_page() ) {
		$classes[] = 'singular';
	}

Attachments (1)

26866.patch (831 bytes) - added by jbkkd 3 years ago.
removed 'singular' class as it wasn't in use

Download all attachments as: .zip

Change History (4)

#1 @lancewillett
4 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.9
  • Priority changed from normal to low

Thanks for this report, looks like the CSS is only in the Print media query block.

@jbkkd
3 years ago

removed 'singular' class as it wasn't in use

#2 @MikeHansenMe
3 years ago

  • Keywords has-patch added; needs-patch removed

#3 @lancewillett
3 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 27571:

Twenty Twelve: remove unused singular selectors in print CSS block. Props jbkkd, fixes #26866.

Note: See TracTickets for help on using tickets.