Context Navigation

← Previous Ticket
Next Ticket →

#26873 closed defect (bug) (fixed)

PHP warning on the Themes page when the active theme is deleted

Reported by:	toszcze	Owned by:	nacin
Priority:	normal	Milestone:	3.9
Component:	Themes	Version:	3.4
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:

Description

When the active theme is deleted from server, the Themes page shows a PHP warning:

Warning: implode(): Invalid arguments passed in /var/www/wordpress/wp-includes/class-wp-theme.php on line 675

To replicate this bug:

In the admin panel go to Appearance -> Themes
Activate any theme
Remove the activated theme folder from server (or just rename it)
Refresh the Themes page

Attachments (2)

26873.diff (492 bytes ) - added by toszcze 12 years ago.
26873.2.diff (956 bytes ) - added by SergeyBiryukov 12 years ago.

Download all attachments as: .zip

Change History (7)

@toszcze
12 years ago

Attachment 26873.diff added

#1 @nacin
12 years ago

Component General → Themes
Milestone Awaiting Review → 3.9
Owner set to nacin
Status new → reviewing

@SergeyBiryukov
12 years ago

Attachment 26873.2.diff added

#2 @SergeyBiryukov
12 years ago

Keywords commit added

This should probably be fixed higher up in the stack, in WP_Theme::display().

See 26873.2.diff , which also fixes inaccurate comment about the @return value.

Also discovered #27235 while testing this.

#3 @SergeyBiryukov
12 years ago

Version trunk → 3.4

#4 @nacin
12 years ago

Resolution → fixed
Status reviewing → closed

In 27745:

WP_Theme: Return false from the display() method when get() fails.

Fixes a potential warning on the themes page when the active theme is deleted.

fixes #26873.

#5 @nacin
12 years ago

After looking at this further, I realized display() should notice a get() failure and also issue a false. This fixes the warning. I added some basic test coverage.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#26873 closed defect (bug) (fixed)

PHP warning on the Themes page when the active theme is deleted

Description

Attachments (2)

Change History (7)

@toszcze 12 years ago

#1 @nacin 12 years ago

@SergeyBiryukov 12 years ago

#2 @SergeyBiryukov 12 years ago

#3 @SergeyBiryukov 12 years ago

#4 @nacin 12 years ago

#5 @nacin 12 years ago