tinymce compat3x plugin adds tooltip en.undefined

[senlin]

As TinyMCE 4.x is in core now the compat3x plugin ensures compatibility. 4.x however uses tooltips and according to ​Andrew Ozz "This seems caused by the compat3x plugin".

[azaozz]

Fixed in [26994]:

TinyMCE: fix error trying to translate non-existent button "title" in the compat3x plugin. See #24067.

[needle]

Is it intentional that this fix prepends the language code to the tooltip text? One of my buttons now has a tooltip that reads "en.My Tooltip Text".

[TobiasBg]

I'm seeing the same issue that @needle describes, with this initialization code for a TinyMCE toolbar button: ​https://plugins.trac.wordpress.org/browser/tablepress/trunk/admin/js/tinymce-button.js#L26

[senlin]

As opposed to what @needle and @TobiasBg describe, I can confirm that the issue that I reported has been solved with the latest update.

[needle]

@senlin, it would be great if you would share the code for creating your button.

[azaozz]

[26994] is specifically for the problem reported in this ticket by @senlin. It removes the undefined part.

The en. part is another bug and probably warrants new ticket, but since it is in the same bit of code, can reuse this one :)

[azaozz]

In 27030:

TinyMCE: fix the compat3x plugin appending 'en.' to button titles. Set charset to UTF-8 in html_entity_decode() for translated strings. See #24067, see #26875.

[senlin]

Replying to needle:

@senlin, it would be great if you would share the code for creating your button.

You can find all details in the link of the original ticket: ​http://make.wordpress.org/core/2014/01/18/tinymce-4-0-is-in-core/#comment-12520

[needle]

@azaozz, [27030] causes my button not to appear at all :(

I have a site with revision 26906 that fails to show the button, while another on 26905 shows it, albeit with the en. prefix

Edit: code ​here on GitHub, if that helps.

[azaozz]

Replying to needle:

@azaozz, [27030] causes my button not to appear at all :(

That should work... Maybe refresh browser cache? Any JS errors?

[needle]

Replying to azaozz:

Replying to needle:

@azaozz, [27030] causes my button not to appear at all :(

That should work... Maybe refresh browser cache? Any JS errors?

Visited in clean browser - nope, no JS errors, no button either.

[azaozz]

Visited in clean browser - nope, no JS errors.

That's strange. Don't see anything in [26906] that can affect this. [26994] and [27030] affect only button titles/tooltips. even without a title arg, a button is still displayed. This works for me:

ed.addButton('commentblock', {
//	title : 'Insert a Comment Block',
	image : url+'/commentblock.jpg',
	cmd : 'COMMENTPRESS_CommentBlock'
});

Maybe add some debugging and see if the plugin is loading properly?

[needle]

Sorry, my bad - just noticed a schoolboy error on my part. Button appears now, with correct tooltip text. Many thanks @azaozz and sorry for the confusion!

[azaozz]

No problems :)

This should be fixed then.