WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#26908 closed enhancement (wontfix)

Add support for custom button types in the wp_fullscreen_buttons filter

Reported by: GregRoss Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.8
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description

The wp_fullscreen_buttons filter only allows you to add 'simple' buttons to the toolbar (no color selectors, dropdown lists, etc.).

The attached patch allows you to add custom HTML to the toolbar to support more complex button types.

Attachments (1)

26908.patch (697 bytes) - added by GregRoss 6 years ago.

Download all attachments as: .zip

Change History (10)

@GregRoss
6 years ago

#1 @GregRoss
5 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
5 years ago

  • Version changed from trunk to 3.8

#3 @azaozz
5 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Thanks @GregRoss. We are moving in a different direction. The new DFW 2.0 (#29806) will be in WordPress 4.1. It works differently (keeps all editor buttons) and replaces the original DFW.

#4 follow-up: @GregRoss
5 years ago

I saw, so it's been decided to remove the full screen mode? The last discussion I saw on it was that it would be left as an option.

I have to admit I don't very much like the new DFW but c'est la vie, it just means I'll have more work to do for my plugin to bring it back ;)

#5 in reply to: ↑ 4 @azaozz
5 years ago

Replying to GregRoss:

This is currently being discussed in https://wordpress.slack.com/messages/feature-focus/ and the consensus is to ask plugins authors to include the old DFW's parts from core in their plugins if they intend to keep it working in its old form. That would also make it much easier for them to change how it works, add new features, etc.

Last edited 5 years ago by azaozz (previous) (diff)

#6 follow-up: @GregRoss
5 years ago

I don't have access to slack, but it would seem that including it in every plugin would make for a lot of incompatibilities and conflicts.

Going from fully supported (4.0) to doesn't exist (4.1) seems a bit sudden. It might make more sense to deprecate it for a couple of releases before removing it completely.

#7 in reply to: ↑ 6 @azaozz
5 years ago

Replying to GregRoss:

I don't have access to slack...

You're welcome to join: https://make.wordpress.org/chat/.

#8 @azaozz
5 years ago

...it would seem that including it in every plugin would make for a lot of incompatibilities and conflicts.

Probably not. Including all of the old DFW in a plugin would give the plugin's author much more freedom to change and improve it. Of course if the user has two plugins that include the old DFW, they might run into conflicts, but that's true for any other component (assuming the plugin(s) will not include the current DFW actions/filters and will use prefixes).

Last edited 5 years ago by azaozz (previous) (diff)

This ticket was mentioned in Slack in #feature-focus by azaozz. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.