Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#26916 closed enhancement (duplicate)

Remove -webkit-box-shadow

Reported by: morganestes's profile morganestes Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.8
Component: Administration Keywords: good-first-bug needs-patch
Focuses: ui Cc:

Description

Adoption of box-shadow by browsers is pretty high, and -webkit- hasn't been needed on it since Safari 5.0 (see http://beta.caniuse.com/#feat=css-boxshadow)

It's time. Less rules == faster loads.

Attachments (1)

26916.patch (20.6 KB) - added by drozdz 11 years ago.
Proposed patch for #26916

Download all attachments as: .zip

Change History (10)

#1 follow-up: @SergeyBiryukov
11 years ago

  • Component changed from General to Administration
  • Keywords ui-focus added
  • Version changed from trunk to 3.8

#2 @morganestes
11 years ago

#26919 was marked as a duplicate.

#3 @morganestes
11 years ago

  • Keywords good-first-bug needs-patch added

#4 in reply to: ↑ 1 ; follow-up: @bassgang
11 years ago

Replying to SergeyBiryukov:
Should we still wait until this ticket is reviewed or does your latest Version change mean: "Go for it"?

#5 in reply to: ↑ 4 ; follow-up: @helen
11 years ago

Replying to bassgang:

Replying to SergeyBiryukov:
Should we still wait until this ticket is reviewed or does your latest Version change mean: "Go for it"?

You don't really need to wait for anything to create a patch. However, note that the version field is not the same as the milestone. Version indicates the earliest affected by a bug or the point where a feature/enhancement was proposed.

I have two things here: one, that I think I would rather handle this through Grunt and Autoprefixer, and the other is that I'm wondering if this is a result of our support for the Kindle browser. Having a hard time finding a definitive resource on it, only vague statements that it's sort-of Android 2.3's browser (which needs -webkit-); any pointers appreciated.

This ticket was mentioned in IRC in #wordpress-dev by bassgang. View the logs.


11 years ago

#7 in reply to: ↑ 5 @bassgang
11 years ago

Replying to helen:

You don't really need to wait for anything to create a patch. However, note that the version field is not the same as the milestone. Version indicates the earliest affected by a bug or the point where a feature/enhancement was proposed.

Thanks for clarification.

I have two things here: one, that I think I would rather handle this through Grunt and Autoprefixer, and the other is that I'm wondering if this is a result of our support for the Kindle browser. Having a hard time finding a definitive resource on it, only vague statements that it's sort-of Android 2.3's browser (which needs -webkit-); any pointers appreciated.

http://en.wikipedia.org/wiki/Kindle_Fire says that the Kindle Fire is "based on Android OS 2.3.3", so if WordPress currently supports this device, we should not remove the -webkit prefix.

Moving the -webkit prefix into a grunt-autoprefixer task sounds good for me.

Kindle HD and HDX are both based on Android OS 4.2.2 according to Wikipedia, so for both of them we do not need the prefix.

@drozdz
11 years ago

Proposed patch for #26916

#8 @morganestes
11 years ago

Okay, so "kill it with fire" may not be the best move if we're trying to support Kindle, but it may be a non-issue all around if we're going to use Grunt and Autoprefixer. Remove them from the current styles and let Grunt handle it if we need to support Kindle.

For the record, Amazon's Silk Developer Guide states that the browser "supports basic CSS3 features like backgrounds, opacity, rounded corners, and text effects, as well as other features" but doesn't mention box-shadow specifically. However, this Modernizr issue on GitHub has a bit more insight as to what is usable.

#9 @nacin
11 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

I tested this on an original Kindle Fire and box-shadow wasn't supported.

At this point, this is a duplicate of #27078.

Note: See TracTickets for help on using tickets.