Changes between Initial Version and Version 1 of Ticket #26922, comment 3
- Timestamp:
- 01/24/2014 05:44:04 AM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #26922, comment 3
initial v1 4 4 > Hi styledev. I think the best step here would be to pass 'none' and then use CSS to add the icon yourself, versus adding more PHP into the mix. SVG benefits from HTML changes, and Dashicons is part of WordPress so it made sense for a special exemption/feature there, but I don't think leaving this to CSS for non-SVG non-Dashicons is much of an issue. 5 5 6 I see what you mean but by passing 'none' you then have to painstakingly add in additional css. This method allows you to just state for instance 'ss-user' and as long the icon set is enqueued properly works very easily.6 I see what you mean but by passing 'none' you then have to painstakingly add in additional css. This method allows you to just state for instance 'ss-user' and as long the icon set is enqueued properly it works very nicely. 7 7 8 8 > As an aside, I'm not sure we'd want to encourage alternative iconsets, as it would be tough to maintain a consistent design that way. Ideally, icons are either a Dashicon or a custom SVG designed with the same aesthetic. This has the added benefit of being "painted" the right color depending on the color scheme in use. … … 10 10 As it stands, we (developers) are already adding in different icons into wp-admin and have been doing so for a long time. So I argue that It is up to the developer to maintain the consistent design for their end-user and in some cases maybe their end-user doesn't care if it is not consistent. 11 11 12 It was already a challenge to find enough icons that fit the old look and feel. Now with the "flat-design" and the growing number of icon fonts out there it is much easier to match the icons than before. As you can see below, symbolset fits nicely into wp-admin and works with the variety of color palette choices.12 It was already a challenge to find enough icons that fit the old look and feel. Now with the "flat-design" and the growing number of icon fonts out there it is much easier to match the icons than before. As you can see below, Symbolset fits nicely into wp-admin and works with the variety of color palette choices. 13 13 14 14 [[Image(http://parapxl.com/wp/wp-admin-symbolset-icon-font.jpg)]]