Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#26924 closed defect (bug) (fixed)

Misleading hook docs for action 'print_media_templates'

Reported by: ericlewis's profile ericlewis Owned by: drewapicture's profile DrewAPicture
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.8
Component: Script Loader Keywords: has-patch
Focuses: docs Cc:

Description


Attachments (2)

26924.diff (402 bytes) - added by ericlewis 11 years ago.
26924.2.diff (4.8 KB) - added by DrewAPicture 11 years ago.
All the prints

Download all attachments as: .zip

Change History (8)

@ericlewis
11 years ago

#1 follow-up: @ericlewis
11 years ago

In attachment:26924.diff, be clear that this hook doesn't actually do anything; it hits after the media manager templates have been printed.

#2 @ericlewis
11 years ago

  • Component changed from Text Changes to Media

#3 in reply to: ↑ 1 @DrewAPicture
11 years ago

  • Keywords needs-patch added

Replying to ericlewis:

In attachment:26924.diff, be clear that this hook doesn't actually do anything; it hits after the media manager templates have been printed.

I agree that the terminology of "Prints" is a bit misleading, though it has also been leveraged with other 'print_*' hooks in core. The hooks don't do anything themselves.

Perhaps 'Fires when xxxx are printed' would be better.

@DrewAPicture
11 years ago

All the prints

#4 @DrewAPicture
11 years ago

  • Component changed from Media to Script Loader
  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.9

#5 @DrewAPicture
11 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 27695:

Correct misleading verbiage in 'print' hook docs.

Standardizes 'print' hook docs on the concept that hooks are fired when scripts and styles are printed.

Props ericlewis for the initial patch.
Fixes #26924.

#6 @DrewAPicture
11 years ago

In 27696:

Fix typo from [27695]. See #26924.

Note: See TracTickets for help on using tickets.