Make WordPress Core

Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#26924 closed defect (bug) (fixed)

Misleading hook docs for action 'print_media_templates'

Reported by: ericlewis Owned by: DrewAPicture
Priority: normal Milestone: 3.9
Component: Script Loader Version: 3.8
Severity: normal Keywords: has-patch
Cc: Focuses: docs

Description


Attachments (2)

26924.diff (402 bytes ) - added by ericlewis 13 years ago.
26924.2.diff (4.8 KB ) - added by DrewAPicture 12 years ago.
All the prints

Download all attachments as: .zip

Change History (8)

@ericlewis
13 years ago

#1 follow-up: @ericlewis
13 years ago

In attachment:26924.diff, be clear that this hook doesn't actually do anything; it hits after the media manager templates have been printed.

#2 @ericlewis
13 years ago

  • Component Text ChangesMedia

#3 in reply to: ↑ 1 @DrewAPicture
13 years ago

  • Keywords needs-patch added

Replying to ericlewis:

In attachment:26924.diff, be clear that this hook doesn't actually do anything; it hits after the media manager templates have been printed.

I agree that the terminology of "Prints" is a bit misleading, though it has also been leveraged with other 'print_*' hooks in core. The hooks don't do anything themselves.

Perhaps 'Fires when xxxx are printed' would be better.

@DrewAPicture
12 years ago

All the prints

#4 @DrewAPicture
12 years ago

  • Component MediaScript Loader
  • Keywords has-patch added; needs-patch removed
  • Milestone Awaiting Review3.9

#5 @DrewAPicture
12 years ago

  • Owner set to DrewAPicture
  • Resolutionfixed
  • Status newclosed

In 27695:

Correct misleading verbiage in 'print' hook docs.

Standardizes 'print' hook docs on the concept that hooks are fired when scripts and styles are printed.

Props ericlewis for the initial patch.
Fixes #26924.

#6 @DrewAPicture
12 years ago

In 27696:

Fix typo from [27695]. See #26924.

Note: See TracTickets for help on using tickets.