WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 3 years ago

#26933 new defect (bug)

Toolbar "Howdy, " message CSS broke in IE

Reported by: bhwebworks Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.8
Component: Toolbar Keywords: has-patch reporter-feedback needs-testing
Focuses: ui Cc:
PR Number:

Description

I noticed this when helping a client with their website, and they were using IE 9. The "Howdy, " message forces their display name down to the next line, causing problems if they try to click the "Screen Options" or "Help" tabs. Plus it just looks bad. (see attached screenshot)

I logged in with IE 11 and saw the same issue, and I chased the bug down to wp-includes/css/admin-bar.css, line 126.

#wpadminbar .quicklinks a,
#wpadminbar .quicklinks .ab-empty-item,
#wpadminbar .shortlink-input {
	height: 32px;
	display: block;
	padding: 0 10px;
	margin: 0;
}

If you change display to inline-block rather than block, it fixes the problem.

Looks like the same code is in admin-bar-rtl.css, and I'm assuming that would have the same issue, but I don't know for sure.

Attachments (3)

howdy in ie11.JPG (11.2 KB) - added by bhwebworks 6 years ago.
Screenshot of IE toolbar "Howdy" message issue
admin-bar.css.patch (404 bytes) - added by 5um17 6 years ago.
26933.2.patch (394 bytes) - added by 5um17 4 years ago.
Patch with overflow: hidden

Download all attachments as: .zip

Change History (12)

@bhwebworks
6 years ago

Screenshot of IE toolbar "Howdy" message issue

#1 @bhwebworks
6 years ago

Suggested code change:

#wpadminbar .quicklinks a,
#wpadminbar .quicklinks .ab-empty-item,
#wpadminbar .shortlink-input {
	height: 32px;
	display: inline-block;
	padding: 0 10px;
	margin: 0;
}

#2 @SergeyBiryukov
6 years ago

  • Keywords reporter-feedback added

Could not reproduce the issue on a clean install neither in IE8 nor IE11. Tried both 3.8.1 and current trunk.

Does it still happen with all plugins disabled and a default theme (Twenty Fourteen or Twenty Thirteen) activated?

#3 @bhwebworks
6 years ago

After further research I found that it's only happening on a few of my sites. I disabled plugins but I didn't go so far as to switch to a default theme.

What I did notice is that it was only happening on sites that were loading (enqueueing) farbtastic.css and media-views.css in the admin.

I wasn't able to determine what those styles had to do with this though.

I do some admin CSS tweaking on my sites, so I just added the fix I mentioned above to that stylesheet, specifically changing display to inline-block, and it's "fixed" for me now.

#4 @SergeyBiryukov
6 years ago

  • Focuses ui added
  • Version changed from trunk to 3.8

#5 @jeremyalzona
6 years ago

#27809 was marked as a duplicate.

#6 @5um17
6 years ago

This only happen in IE when Avatars are disabled. Seems like text is being wrapped around the floated user icon instead of being wide.
In place of adding inline-block to all elements, i made inline-block to this element only, it will not effect on other browsers as it is a floated element and this fix the problem in IE.

@5um17
6 years ago

#7 @chriscct7
4 years ago

  • Keywords has-patch added; reporter-feedback removed

#8 @5um17
4 years ago

Updating patch in favor of better approach to handle this IE bug. Actually IE is not respecting floated icons thus having width: auto only expend the div to fit the text but not the icon.

In this case we can also add overflow: hidden; to a tag, which will not reflect any change on other browsers.

@5um17
4 years ago

Patch with overflow: hidden

#9 @swissspidy
3 years ago

  • Keywords reporter-feedback needs-testing added

Is this still an issue with latest versions of WordPress and Internet Explorer?

Note: See TracTickets for help on using tickets.