Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#26942 closed defect (bug) (invalid)

Unnecessary $sites count condition in multisite load process

Reported by: jeremyfelt Owned by:
Priority: low Milestone:
Component: Bootstrap/Load Version: 3.0
Severity: minor Keywords: has-patch
Cc: Focuses: multisite

Description

mu:1422 moved a check for single network vs multi-network into wpmu_current_site(). Existing code inside wpmu_current_site() intended for a $sites count of 1 become inaccessible.

In [12921], the remaining count checks were consolidated into one, but the instance of 1 == count( $sites ) in that scenario is still not accessible.

This doesn't hurt anything and the likelihood of this part of the function being reached is so extremely low. It does cause a double take. And made me investigate it.

Attachments (1)

26942.diff (882 bytes ) - added by jeremyfelt 13 years ago.

Download all attachments as: .zip

Change History (2)

@jeremyfelt
13 years ago

#1 @jeremyfelt
13 years ago

  • Milestone Awaiting Review
  • Resolutioninvalid
  • Status newclosed

Closing in favor of the work being done in #27003

Note: See TracTickets for help on using tickets.