WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#26950 closed defect (bug) (fixed)

Twenty Eleven broken screen reader link

Reported by: gluten Owned by: lancewillett
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Bundled Theme Keywords: has-patch
Focuses: accessibility Cc:

Description

The Twenty Eleven theme adds two skip links for accessibility: "skip to primary content" and "skip to secondary content". The problem is, the "secondary content" does not always exist. All singular posts and pages do not have the linked-to secondary content section, rendering the link broken on all of those pages.

Since none of the default themes since Twenty Eleven have had a second skip link, it seems like removing the secondary skip link entirely would be the best course of action.

Attachments (2)

26950.patch (1.5 KB) - added by bcworkz 6 years ago.
26950.no-title.patch (2.1 KB) - added by bcworkz 6 years ago.
Title attributes removed

Download all attachments as: .zip

Change History (8)

#1 @gluten
6 years ago

  • Component changed from Themes to Bundled Theme

#2 @lancewillett
6 years ago

  • Milestone changed from Awaiting Review to 3.9
  • Version set to trunk

@bcworkz
6 years ago

#3 @bcworkz
6 years ago

  • Keywords has-patch added

Removing the link would be easy, but I don't like the idea of removing established functionality. It's not so difficult to make the link output conditional on !is_singular().

#4 follow-up: @johnbillion
6 years ago

The title attribute on these links are also redundant.

@bcworkz
6 years ago

Title attributes removed

#5 in reply to: ↑ 4 @bcworkz
6 years ago

Replying to johnbillion:

The title attribute on these links are also redundant.

Nearly all title attributes are at least conceptually redundant. These are literally redundant! As it happens the original 26950.patch is unusable, I somehow dropped the ! modifier to is_singular(), so 26950.no-title.patch is the only usable patch at this point.

#6 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 27569:

Twenty Eleven: only show secondary skip link on pages with secondary content, and remove duplicate title attribute in site title output. Props bcworkz, fixes #26950.

Note: See TracTickets for help on using tickets.