Support https URLs in Twitter embeds

[mattheweppelsheimer]

In WP 3.8.1, URLS to embed tweets in posts only work with the http protocol. They fail with https. I find this to be counterintuitive, since all of twitter.com seems to be served through https.

I realize we are limited by Twitter's APIs, but it seems it should be possible to support both. If Twitter's API requires https, perhaps the embed detection code can do the conversion before sending the request.

First time reporter. I sure hope I'm doing this right! ;-)

FYI I reviewed all discussion of #26844 and didn't see mention of this.

[mattheweppelsheimer]

Replying to mattheweppelsheimer:

I realize we are limited by Twitter's APIs, but it seems it should be possible to support both. If Twitter's API requires https, perhaps the embed detection code can do the conversion before sending the request.

Right, I meant "If Twitter's API requires http, …".

[ericmann]

I just tested this on a live 3.8.1 site and can't reproduce it. Great report, though, but perhaps a list of what theme you're using and plugins and such would help clarify what's going on.

[ocean90]

If Twitter's API requires https, perhaps the embed detection code can do the conversion before sending the request.

Which we currently do, see tags/3.8.1/src/wp-includes/class-oembed.php#L49​.