WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#26967 closed defect (bug) (fixed)

Admin Help on edit-comments.php is incorrect

Reported by: siobhan Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: minor Version: 3.9
Component: Comments Keywords: has-patch
Focuses: ui Cc:

Description

The admin help on edit-comments.php (under Moderating Comments) says the following:

A yellow row means the comment is waiting for you to moderate it.

This is incorrect. A comment that requires moderation has a red bar beside it.

Attachments (3)

26967.patch (2.4 KB) - added by bcworkz 6 years ago.
comments-background.zip (206.9 KB) - added by bcworkz 6 years ago.
color variations - HTML and supporting files
26967.2.patch (3.2 KB) - added by samuelsidler 6 years ago.
Update all the reds + new text

Download all attachments as: .zip

Change History (21)

#1 @siobhan
6 years ago

  • Focuses docs added
  • Keywords good-first-bug added
  • Severity changed from normal to minor

#2 follow-up: @siobhan
6 years ago

  • Keywords needs-patch added

#3 follow-up: @nacin
6 years ago

  • Component changed from Text Changes to Comments
  • Focuses ui added
  • Keywords good-first-bug removed
  • Milestone changed from Awaiting Review to 3.9

It seems that the row is also yellow, but it's so faint that it's barely discernible (and is probably not discernible on a worse monitor). I was moderating a bunch of comments the other day and was really struggling. I would prefer if the yellow were more obvious — or, at the very least, it's apparent I'm not used to the red bar.

I think this is a UI issue, not just a documentation issue. Flagging for attention.

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.


6 years ago

#5 in reply to: ↑ 3 @siobhan
6 years ago

Replying to nacin:

It seems that the row is also yellow, but it's so faint that it's barely discernible (and is probably not discernible on a worse monitor). I was moderating a bunch of comments the other day and was really struggling. I would prefer if the yellow were more obvious — or, at the very least, it's apparent I'm not used to the red bar.

I think this is a UI issue, not just a documentation issue. Flagging for attention.

Totally agree that it's a UI issue - I didn't notice the yellow and I'm on a retina screen. I'm fairly used to the red bar now but it doesn't make it stand out all that much. A stronger colour for the background of comments awaiting moderation would make a big difference.

@bcworkz
6 years ago

#6 follow-up: @bcworkz
6 years ago

  • Keywords has-patch added; needs-patch removed

It's funny how colors are not very discernible at low saturations and high values. Yellow? I increased the saturation of the color taken from CSS in GIMP and it's actually a burnt orange, as is the "red" bar. Since most people would still call this color "red", I stuck with the terminology and called it a "light pink" bar. I upped the saturation just a tad. We don't want to over do it or else it will look garish on monitors with really saturated display colors.

#7 in reply to: ↑ 6 @siobhan
6 years ago

Replying to bcworkz:

It's funny how colors are not very discernible at low saturations and high values. Yellow? I increased the saturation of the color taken from CSS in GIMP and it's actually a burnt orange, as is the "red" bar. Since most people would still call this color "red", I stuck with the terminology and called it a "light pink" bar. I upped the saturation just a tad. We don't want to over do it or else it will look garish on monitors with really saturated display colors.

That's better, but it's still quite subtle. For people who have even minor sight difficulties it might be difficult to distinguish.

@bcworkz
6 years ago

color variations - HTML and supporting files

#8 follow-up: @bcworkz
6 years ago

Just the right color saturation is very subjective and also dependent on one's monitor. I made up a sample page with increasing saturation of the same hue and value as you scroll down. I of course thought 5% was adequate, but I have no problem with more. IMO we shouldn't go over 13% because it gets out of balance with other backgrounds. But I offered higher values just in case.

I wouldn't want to go any more than is necessary because some monitors are quite saturated and even the original shade was quite evident. But it does need to be enough for those with less saturated monitors as well. Where is that happy medium?

#9 in reply to: ↑ 8 ; follow-up: @siobhan
6 years ago

Replying to bcworkz:

Just the right color saturation is very subjective and also dependent on one's monitor. I made up a sample page with increasing saturation of the same hue and value as you scroll down. I of course thought 5% was adequate, but I have no problem with more. IMO we shouldn't go over 13% because it gets out of balance with other backgrounds. But I offered higher values just in case.

I wouldn't want to go any more than is necessary because some monitors are quite saturated and even the original shade was quite evident. But it does need to be enough for those with less saturated monitors as well. Where is that happy medium?

Maybe relying on colour, which can vary from monitor to monitor, and which is also affected by people's eyesight, is the wrong approach?

Update: I've just logged into a WordPress 3.7 install and the contrast between the unmoderated and moderated comments is really clear.

Last edited 6 years ago by siobhan (previous) (diff)

#10 in reply to: ↑ 9 @bcworkz
6 years ago

Replying to siobhan:

Update: I've just logged into a WordPress 3.7 install and the contrast between the unmoderated and moderated comments is really clear.

FWIW, the saturation of the 3.7 color is 12%, sort of what I indicated as maximum to match other backgrounds, though the hue is obviously different. I think humans perceive certain hues as "brighter" than others, given equal value and saturation in the HSV color model. While the MP6/3.8 designers went much lighter with the background, I think they realized some people would not notice it and thus added the red bar to the left which is plenty enough cue IMO without any difference in the backgrounds.

On one of my monitors the 3.7 color is quite dramatic, on another it's rather insipid and the 3.8 color amped up to 11% stands out much more. Go figure. It's a no win situation. What looks good on one monitor will be awful on another. Someone with a calibrated monitor ought to decide what looks pleasing and the rest of us should just put up with the result :)

#11 @DrewAPicture
6 years ago

  • Focuses docs removed

This ticket was mentioned in IRC in #wordpress-dev by kimparsell. View the logs.


6 years ago

#13 follow-up: @helen
6 years ago

  • Keywords needs-patch added; has-patch removed

I think the first color, as per the patch, seems fine. I don't think we can pretend that's a light pink, though - perhaps referencing a thicker red border is enough for help text right now. Let's come up with something better there before a commit, at any rate.

I think maybe we should explore other additional options in a separate ticket for a future release. Maybe something like an icon under the checkbox, where the post edit lock icon shows in post list tables. I don't think solely relying on color is enough - the border is helpful, but it's possible for, say, a custom comment status to use the same thicker border but in a different color. Icons would decouple from relying on color. Not the only option, just brainstorming a bit.

#14 in reply to: ↑ 13 @samuelsidler
6 years ago

Replying to helen:

I think the first color, as per the patch, seems fine. I don't think we can pretend that's a light pink, though - perhaps referencing a thicker red border is enough for help text right now. Let's come up with something better there before a commit, at any rate.

How about: "A red bar on the left means the comment is waiting for you to moderate it."

Last edited 6 years ago by samuelsidler (previous) (diff)

#15 @nacin
6 years ago

  • Keywords needs-refresh added

This patch needs a refresh for both the string and the color.

@samuelsidler
6 years ago

Update all the reds + new text

#16 @samuelsidler
6 years ago

  • Keywords has-patch added; needs-patch needs-refresh removed

26967.2.patch updates the red throughout the CSS (also seen on the plugin lists and theme modal when an update is available) and adds the new text.

#17 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27774:

Comments: Update border color and help text.

props bcworkz.
fixes #26967.

#18 in reply to: ↑ 2 @josephallotey3
6 years ago

Replying to siobhan:
add up

Note: See TracTickets for help on using tickets.