WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#26982 closed enhancement (wontfix)

Permit custom field elements in left column of Quick Edit

Reported by: danielbachhuber Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Quick/Bulk Edit Keywords:
Focuses: administration Cc:

Description

Quick Edit supports adding custom fields via the quick_edit_custom_box action. Due to the two-column layout and where the action is called, it isn't easily possible to add your custom field in the left column of Quick Edit — only the right column.

If the design of Quick Edit is established indefinitely, it would be nice to have an additional action to place custom field elements in the left column.

Attachments (2)

26982.1.diff (910 bytes) - added by danielbachhuber 6 years ago.
Add "after" actions for each of Quick Edit's columns
26982.diff (1.4 KB) - added by DrewAPicture 6 years ago.
Single inline_edit_after_column hook + docs

Download all attachments as: .zip

Change History (7)

#1 @danielbachhuber
6 years ago

For reference, here was my immediate "fix". I'll upload a patch with my proposal.

@danielbachhuber
6 years ago

Add "after" actions for each of Quick Edit's columns

#2 @DrewAPicture
6 years ago

  • Focuses docs added
  • Keywords 2nd-opinion added

Instead of introducing what appears to be 6 new hooks, what about introducing 2 new hooks with a context parameter for left, center, or right. Even better, we could just introduce a single new hook, passing both a $bulk and context parameter.

Regardless, whatever we end up with will need hook docs.

@DrewAPicture
6 years ago

Single inline_edit_after_column hook + docs

#3 @DrewAPicture
6 years ago

  • Focuses administration added; docs removed
  • Keywords dev-feedback has-patch added; 2nd-opinion removed

26982.diff combines the new hooks into a single a new hook with a $context parameter and $bulk. Not sure if using a boolean in this way is really recommended but it could work. Also adds hook docs.

#4 @nacin
6 years ago

The templating of Quick Edit needs an overhaul at some point down the line. Additional hooks, especially one wedded to the idea of "columns" (which, for responsive situations, is different), is probably gonna make it tougher to improve Quick Edit, both from the technical perspective (how we template it) and also how it looks and works (it could benefit from an update). (The next step, if I had to guess, is Underscore templates and Backbone.)

I'm not quite saying wontfix, I'm just saying we've never had very good luck when we've taken a giant block of HTML and loaded it up with a ton of actions. It usually bites us really hard later. Honestly, that JS hack doesn't bother me all that much. After all, this is a JS-driven feature.

#5 @danielbachhuber
6 years ago

  • Keywords dev-feedback has-patch removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I'm fine with wontfix for now then. The JS hack seems to work well-enough, and I agree that adding more actions isn't the ideal way to go about it.

Note: See TracTickets for help on using tickets.