#27023 closed task (blessed) (fixed)
As a developer, I should be able to easily get and apply patches from trac
Reported by: | jorbin | Owned by: | |
---|---|---|---|
Milestone: | 3.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch |
Focuses: | Cc: |
Description
getting and applying patches from core.trac.wordpress.org can be a bit of a hassle. Find the ticket, look at the patch, scroll to the bottom. Download the original. What if it was as easy as entering a trac url? or ticket number? Or the not raw patch url?
That is what this aims to solve.
To use:
grunt patch # This will look for patches in your root checkout grunt patch:18380 # This will look for patches on ticket 18380 and let you choose which one to install grunt patch:https://core.trac.wordpress.org/ticket/18380 # same as above grunt patch:https://core.trac.wordpress.org/attachment/ticket/18380/18380.4.diff # Will download and apply that specific patch
Attachments (5)
Change History (26)
This ticket was mentioned in IRC in #wordpress-dev by jorbin_work. View the logs.
11 years ago
#2
follow-ups:
↓ 3
↓ 4
@
11 years ago
This is awesome.
When asking for all patches for a ticket, it would be awesome if it could show you the author of the patch and the relative time since it was uploaded (as Trac shows). I'm trying to do it myself but my JS regex-fu is a little weak today.
#3
in reply to:
↑ 2
;
follow-up:
↓ 9
@
11 years ago
#4
in reply to:
↑ 2
@
11 years ago
Replying to nacin:
When asking for all patches for a ticket, it would be awesome if it could show you the author of the patch and the relative time since it was uploaded (as Trac shows). I'm trying to do it myself but my JS regex-fu is a little weak today.
Agreed. Also, Done. Also included the size of the patch.
This ticket was mentioned in IRC in #wordpress-dev by bassgang. View the logs.
11 years ago
#7
@
11 years ago
We will need to update
http://make.wordpress.org/core/handbook/working-with-patches/patches-with-command-line/
when/if this is committed.
#9
in reply to:
↑ 3
@
11 years ago
Replying to Denis-de-Bernardy:
It's also a dup of #9724, which I never understood why you closed as workforme.
If I had to guess, it's because build tools didn't belong to the core repository at the time. However, you could always add them to relevant Codex pages.
This ticket was mentioned in IRC in #wordpress-dev by jorbin. View the logs.
11 years ago
This ticket was mentioned in IRC in #wordpress-dev by jorbin. View the logs.
11 years ago
#12
@
11 years ago
Fixed a bug where only having one patch|diff in your directory caused patching to fail. Thanks @nacin for the report.
Also updated some spacing, grammar, and wording of the instructions. Thanks @nacin @evarlese and @helen
This ticket was mentioned in IRC in #wordpress-dev by jorbin. View the logs.
11 years ago
This ticket was mentioned in IRC in #wordpress-dev by jorbin. View the logs.
11 years ago
This ticket was mentioned in IRC in #wordpress-dev by jorbin. View the logs.
11 years ago
#17
follow-up:
↓ 18
@
11 years ago
Noticing a couple things:
- If I apply a patch that was done within /src or before /src, it fails - I think it should be smart about it the same way it does for the other way around (which does work).
- I'd also want to see successfully modified files.
#18
in reply to:
↑ 17
@
11 years ago
Replying to helen:
- If I apply a patch that was done within /src or before /src, it fails - I think it should be smart about it the same way it does for the other way around (which does work).
This is tracked at https://github.com/aaronjorbin/grunt-patch-wordpress/issues/3 I'm going to start working on adding it next week.
- I'd also want to see successfully modified files.
I like this idea. Thanks!
spaces, not tabs (fml)