Make WordPress Core

Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#2707 closed defect (bug) (invalid)

smiley converter creates URLs with the wrong base - patch included

Reported by: peregrine's profile peregrine Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.0.2
Component: General Keywords: bg|dev-feedback bg|has-patch
Focuses: Cc:

Description

I have the "WordPress Address" option set to an https:// URI and the "Blog Address" URI set to the http:// location.

I posted an article in which I had included a :( "smiley" (or should I call it a "frowny" in this case :) ?). It produced an https:// URL for the image. This caused users of a Planet that aggregates my blog to see a dialog in their browsers asking them to decide what to do with my self-signed-only certificate.

A little diggin and I came up with this patch to the wp-include/vars.php file, which I will attach.

Attachments (1)

wordpress-smileies-2.0.2.patch (614 bytes) - added by peregrine 16 years ago.
diff -u patch for wp-include/vars.php that fixes this bug.

Download all attachments as: .zip

Change History (5)

@peregrine
16 years ago

diff -u patch for wp-include/vars.php that fixes this bug.

#1 @MattRead
16 years ago

I think the "wordpress address" has to be used, cause it's the full path the the wp-* dirs, whereas "blog address" is the path to the permalinks base. so if you install in /wordpress/ and serve from /, the paths to the smilies will be off.... interesting dilemma.

#2 @westi
16 years ago

  • Keywords bg|dev-feedback bg|has-patch added
  • Milestone set to 2.0.3
  • Priority changed from high to normal

I think we can say that this patch is invalid for the reason MattRead states above.

If you want a secure admin can you not use the SecureAdmin plugin?

#3 @ryan
16 years ago

  • Resolution set to invalid
  • Status changed from new to closed

#4 @(none)
15 years ago

  • Milestone 2.0.3 deleted

Milestone 2.0.3 deleted

Note: See TracTickets for help on using tickets.