WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27075 closed enhancement (fixed)

Twenty Fourteen: add "button" CSS class for styling elements as buttons

Reported by: celloexpressions Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:
PR Number:

Description

It is often desirable to style links or other elements as buttons for various purposes. In-content this allows very important (user-flow-type) links to gain emphasis (ex. "become a member" at the end of an about page). In plugins, it allows buttons that aren't technically buttons to inherit the theme's styling instead of creating their own, duplicating the theme's styling on a custom id (ex. Jetpack's infinite scroll), or using hacks to use the button-type elements that are styled by the theme.

In Twenty Fourteen itself, .contributor-posts-link would benefit from using .button for its generic button styling, plus the more specific class for styling specific to that particular button.

The use of the .button class in wp-admin provides inspiration for this proposal, as it has use cases on the front-end as well.

Attachments (2)

27075.button-only.diff (1.1 KB) - added by celloexpressions 6 years ago.
Add a .button class
27075.diff (2.0 KB) - added by celloexpressions 6 years ago.
Add a .button class and use it for the contributor posts link.

Download all attachments as: .zip

Change History (6)

@celloexpressions
6 years ago

Add a .button class

@celloexpressions
6 years ago

Add a .button class and use it for the contributor posts link.

#1 @celloexpressions
6 years ago

  • Keywords has-patch added

#2 @lancewillett
6 years ago

  • Milestone changed from Awaiting Review to 3.9

+1 Let's try to get this in for 3.9 cycle.

This ticket was mentioned in IRC in #wordpress-dev by celloexpressions. View the logs.


6 years ago

#4 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27442:

Twenty Fourteen: Add a .button class.

props celloexpressions.
fixes #27075.

Note: See TracTickets for help on using tickets.