WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#27109 closed defect (bug) (fixed)

Wrong $parent_file value in wp-admin/update-core.php

Reported by: SergeyBiryukov Owned by:
Milestone: 3.9 Priority: normal
Severity: trivial Version: 3.0
Component: Upgrade/Install Keywords: good-first-bug has-patch commit
Focuses: administration Cc:

Description (last modified by SergeyBiryukov)

When Updates menu item was moved from Tools to Dashboard in [13588], $parent_file was not updated: tags/3.8.1/src/wp-admin/update-core.php#L459.

get_admin_page_parent() correctly overrides it with index.php. This leaves me wondering if the explicit declaration is actually necessary, but we have it on other admin screens as well, so let's just update it.

Attachments (1)

27109.patch (807 bytes) - added by bcworkz 7 years ago.

Download all attachments as: .zip

Change History (5)

#1 @SergeyBiryukov
7 years ago

  • Description modified (diff)

@bcworkz
7 years ago

#2 @bcworkz
7 years ago

  • Keywords needs-patch removed

Here ya go. FWIW I could not discover any issues by simply deleting it, but the patch does update anyway.

#3 @SergeyBiryukov
7 years ago

  • Description modified (diff)
  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 3.9
  • Severity changed from normal to trivial

#4 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [27205].

Note: See TracTickets for help on using tickets.