WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#27115 closed task (blessed) (fixed)

HTTPS links to wordpress.org

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.4 Priority: low
Severity: minor Version:
Component: Administration Keywords: has-patch meta
Focuses: administration Cc:

Description

It appears that wordpress.org now favours an SSL connection, although it is not currently enforced. Googling for WordPress returns a link to https://wordpress.org and once you're on the site, the HTTPS links persist.

We should convert all wordpress.org links in the dashboard to HTTPS links.

Any objections?

Attachments (18)

27115.xmlrpc.diff (777 bytes) - added by Ipstenu 6 years ago.
XMLRPC diff'd
27115.readme.diff (5.7 KB) - added by Ipstenu 6 years ago.
Readme
27115.wp-login.diff (458 bytes) - added by Ipstenu 6 years ago.
wp login
27115.all.diff (84.2 KB) - added by Ipstenu 6 years ago.
Everything (except wp-content files for obv reasons)
27115.all.2.diff (39.7 KB) - added by Ipstenu 6 years ago.
Missed some.
27115.diff (39.4 KB) - added by markjaquith 6 years ago.
27115.patch (102.2 KB) - added by bravokeyl 6 years ago.
Codex links ..
27115.2.patch (103.6 KB) - added by netweb 5 years ago.
27115-twenty-ten.patch (5.3 KB) - added by netweb 5 years ago.
27115-twenty-eleven.patch (8.2 KB) - added by netweb 5 years ago.
27115-twenty-twelve.patch (6.9 KB) - added by netweb 5 years ago.
27115-twenty-thirteen.patch (7.6 KB) - added by netweb 5 years ago.
27115-twenty-fourteen.patch (8.3 KB) - added by netweb 5 years ago.
27115.wporg.diff (7.9 KB) - added by Ipstenu 5 years ago.
More wordpress.org links to https
27115.codex.diff (78.9 KB) - added by MikeHansenMe 5 years ago.
codex links
31882.use-https-codex-urls.patch (94.9 KB) - added by ramiy 4 years ago.
Codex links
31882.use-https-in-readme-and-config.patch (5.2 KB) - added by ramiy 4 years ago.
readme.txt & wp-config-sample.php
27115.3.patch (13.7 KB) - added by ocean90 4 years ago.
Remaining http://wordpress.org links.

Download all attachments as: .zip

Change History (62)

#1 @nacin
6 years ago

  • Keywords needs-patch added; dev-feedback removed
  • Milestone changed from Awaiting Review to 3.9

None. It'll be enforced soon.

#2 @johnbillion
6 years ago

  • Owner set to johnbillion
  • Status changed from new to accepted

@Ipstenu
6 years ago

XMLRPC diff'd

@Ipstenu
6 years ago

Readme

@Ipstenu
6 years ago

wp login

@Ipstenu
6 years ago

Everything (except wp-content files for obv reasons)

#3 @Ipstenu
6 years ago

  • Keywords has-patch added; needs-patch removed

I did three on their own and then I THINK I got it with the all, but given the rapid movement of WP, it may not be a great idea to use that. I omitted wp-content from my search/replace, since I didn't want to accidentally touch themes and plugins.

@Ipstenu
6 years ago

Missed some.

#4 @johnbillion
6 years ago

There's a good deal more than this. There's codex.wordpress.org, make.wordpress.org, and planet.wordpress.org links too.

Additionally, the feed URLs in wp-admin/includes/dashboard.php shouldn't change in case the site can't perform outgoing SSL requests.

@markjaquith
6 years ago

#5 @markjaquith
6 years ago

Refreshed. Rolled back a few. Anything that is used by the server to make requests should NOT be changed.

#6 @nacin
6 years ago

In 27369:

Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc.

props Ipstenu, markjaquith.
see #27115.

#7 @nacin
6 years ago

I also removed the generator-like links used in XML-RPC (<engineLink>) and <meta generator> tags.

#8 @nacin
6 years ago

  • Type changed from enhancement to task (blessed)

#9 @nacin
6 years ago

In 27469:

Use SSL when linking to WordPress.org. see #27115.

#10 @johnbillion
6 years ago

  • Keywords has-patch removed
  • Milestone changed from 3.9 to Future Release

Moving to Future Release for the Codex, Make and Planet links.

@bravokeyl
6 years ago

Codex links ..

#11 @bravokeyl
6 years ago

What about trac.wordpress.org/* or core.trac.wordpress.org/* links

Last edited 6 years ago by bravokeyl (previous) (diff)

@netweb
5 years ago

#12 @netweb
5 years ago

27115.2.patch refreshes bravokeyl 27115.patch​ above against develop trunk includes /wp-config-sample.php

#13 @netweb
5 years ago

Also available are the following domains and are SSL enabled:

#14 follow-up: @markjaquith
5 years ago

In 29787:

Use HTTPS links for planet.wordpress.org

see #27115

#15 @markjaquith
5 years ago

In 29788:

Use HTTPS URLs for core.trac.wordpress.org

see #27115

#16 @markjaquith
5 years ago

In 29789:

Use HTTPS URLs for trac.wordpress.org (and use core.trac.wordpress.org)

see #27115

#17 in reply to: ↑ 14 @nacin
5 years ago

Replying to markjaquith:

In 29787:

Use HTTPS links for planet.wordpress.org

see #27115

FWIW, planet.wordpress.org isn't yet forced SSL due to mixed content warnings. Will be worked on in #meta634.

#18 @TobiasBg
5 years ago

  • Keywords needs-refresh needs-patch added
  • Milestone changed from Future Release to 4.1

There are multiple links to http://wordpress.org/ URLs in Core, core themes, unit tests, makepot, ... that do get redirected to https:// and therefore should be converted.

make also seems to be redirecting. planet and codex don't, yet.

@Ipstenu
5 years ago

More wordpress.org links to https

#19 @Ipstenu
5 years ago

Added 27115.wporg.diff - more of the wordpress.org URLs

Looking at the codex, I don't know if we want to force that over yet, since I know we're slowly weaning the codex away. not that it would be BAD to...

#20 @Jayjdk
5 years ago

Is wp-admin/setup-config.php supposed to be changed in 27115.wporg.diff?

#21 @nacin
5 years ago

Yes to forcing the Codex. I'm not sure there's anything on *.wordpress.org that isn't forced SSL at this point.

#22 @MikeHansenMe
5 years ago

  • Keywords has-patch added; needs-refresh needs-patch removed

#23 @johnbillion
5 years ago

  • Keywords 4.2-early needs-patch added; has-patch removed
  • Milestone changed from 4.1 to Future Release

Needs a patch for codex.wordpress.org links. Moving this to 4.2 to avoid a load of late string changes.

#24 @iseulde
5 years ago

  • Milestone changed from Future Release to 4.2

See comment above.

@MikeHansenMe
5 years ago

codex links

#25 @MikeHansenMe
5 years ago

  • Keywords needs-patch removed

#26 @johnbillion
5 years ago

  • Keywords has-patch added; 4.2-early removed

#27 @DrewAPicture
5 years ago

  • Keywords needs-refresh added

Looks like 27115.codex.diff needs a refresh in wp-admin/user-edit.php:

patching file src/wp-admin/user-edit.php
Hunk #2 FAILED at 273.
1 out of 2 hunks FAILED

#28 @johnbillion
5 years ago

I was talking to ocean90 about this. Him and I are going to coordinate the remaining change so we don't trigger the need for translators to re-translate the huge number of strings which are affected.

#29 @SergeyBiryukov
5 years ago

In 31839:

Bundled themes: Use SSL for theme and author URIs.

props mercime.
fixes #31699. see #27115.

#30 @DrewAPicture
4 years ago

  • Keywords needs-refresh removed

This ticket was mentioned in Slack in #core by drew. View the logs.


4 years ago

#32 @DrewAPicture
4 years ago

  • Keywords 4.2-strings added

This ticket was mentioned in Slack in #core by drew. View the logs.


4 years ago

#34 @johnbillion
4 years ago

#31882 was marked as a duplicate.

@ramiy
4 years ago

Codex links

@ramiy
4 years ago

readme.txt & wp-config-sample.php

This ticket was mentioned in Slack in #core by drew. View the logs.


4 years ago

#36 @DrewAPicture
4 years ago

  • Keywords meta added

This ticket was mentioned in Slack in #core by drew. View the logs.


4 years ago

#38 @ocean90
4 years ago

In 32116:

Use HTTPS URLs for codex.wordpress.org.

see #27115.

@ocean90
4 years ago

Remaining http://wordpress.org links.

#39 @johnbillion
4 years ago

  • Keywords 4.2-strings removed

Remaining http://wordpress.org links.

See comment 4 and comment 6 regarding feed URLs.

#40 @johnbillion
4 years ago

  • Milestone changed from 4.2 to Future Release

This ticket was mentioned in Slack in #polyglots by netweb. View the logs.


4 years ago

#42 @johnbillion
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 34783:

Switch the remaining user-facing links to wordpress.org over to HTTPS.

Fixes #27115

#43 @johnbillion
4 years ago

In 34784:

shttp is not a protocol.

See #27115

#44 @netweb
4 years ago

  • Milestone changed from Future Release to 4.4

Commits above go back to the 3.9 milestone, fixed tickets needs a milestone, the last commit will ship in 4.4, 4.4 it is

Note: See TracTickets for help on using tickets.