WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#27121 closed enhancement (fixed)

Add a grunt task that encompasses all pre-commit activities

Reported by: jorbin Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

In #25169 and #27078 , it is mentioned that autoprefixer and imagemin are designed to be run before commit. We should consolidate all the tasks that we expect to be run before a commit into one task so none of them are forgotten.

This also makes it so patch creators can run the same steps as committers which will hopefully lead to to better patches that are easier to review and commit.

Attachments (2)

27121.diff (525 bytes) - added by jorbin 5 years ago.
27121.2.diff (549 bytes) - added by jorbin 5 years ago.

Download all attachments as: .zip

Change History (7)

@jorbin
5 years ago

#1 @jorbin
5 years ago

  • Keywords has-patch added

The above patch sets four tasks (one of which contains multiple tasks) that are to be run.

AutoPrefixer:core ( see #27078 )
imagemin:core ( see #25169 )
jshnit
test (which runs both the phpunit tests and the qunit tests )

#2 @nacin
5 years ago

I had this locally already. Nice. :-)

This ticket was mentioned in IRC in #wordpress-dev by jorbin. View the logs.


5 years ago

@jorbin
5 years ago

#4 @jorbin
5 years ago

Patch updated based on irc conversation. It is only focussing on front end tasks and phpunit takes a while, so we are leaving that off.

#5 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27176:

Add grunt precommit for running front-end dev and test tasks before commit.

This includes autoprefixer, imagemin, jshint, and qunit.

props jorbin.
fixes #27121. see #25169 and #27078.

Note: See TracTickets for help on using tickets.