WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27128 closed defect (bug) (fixed)

Theme installator - ajax error message

Reported by: vinvin27 Owned by: SergeyBiryukov
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.4
Component: Themes Keywords: has-patch commit
Focuses: administration Cc:

Description

Hi,

I getting ajax error when i opening theme in new tab, only themes were loaded in ajax.

If there are so many results, other themes are loading, opening in current tab is OK but in new tab i getting this message :

{"rows":"
Aucun th\u00e8me ne correspond \u00e0 votre requ\u00eate.<\/div>"}

Cheers :)

Attachments (1)

27128.patch (504 bytes) - added by ocean90 6 years ago.

Download all attachments as: .zip

Change History (6)

#1 @ocean90
6 years ago

  • Component changed from General to Themes
  • Keywords reporter-feedback added

Hello vinvin27, thanks for the report.

Can you please provide some more steps to reproduce the issue? Does the same happens with no active plugins and the default theme? Also can you run your install in English so that the error message is in English too? Thanks!

#2 follow-up: @vinvin27
6 years ago

Hi :)

No activate plugins and with default theme :)

Steps (in back-office) :

1) Go to appareance settings
2) Add new
3) Search themes without keywords
4) With first results (36 results), i openning in new tab that's works (for example :
/wp-admin/theme-install.php?tab=theme-information&s&search=Search&theme=pinboard)
I clicking on themes picture
5) However, with new results (loader in ajax), if i openning in new tab :
(for example :
/wp-admin/admin-ajax.php?action=fetch-list&paged=2&s&tab=theme-information&type=term&_ajax_fetch_list_nonce=a94130d631&list_args%5Bclass%5D=WP_Theme_Install_List_Table&list_args%5Bscreen%5D%5Bid%5D=theme-install&list_args%5Bscreen%5D%5Bbase%5D=theme-install&theme=cybermag
)

{"rows":"
No themes match your request.<\/div>"}

I hope i help you :)

Same "bug" with wordpress 3.8.1

#3 in reply to: ↑ 2 @ocean90
6 years ago

  • Keywords needs-patch added; reporter-feedback removed
  • Milestone changed from Awaiting Review to 3.9

Replying to vinvin27:

I hope i help you :)

You did, many thanks! Working on a patch.

@ocean90
6 years ago

#4 @ocean90
6 years ago

  • Keywords has-patch commit added; needs-patch removed
  • Version changed from 3.8.1 to 3.4

Introduced in [20140].

27128.patch builds the preview URL with self_admin_url( 'theme-install.php' ) instead of $_SERVER['REQUEST_URI'].

#5 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 27247:

Fix theme preview URL for themes loaded via AJAX on Install Themes screen.

props ocean90.
fixes #27128.

Note: See TracTickets for help on using tickets.