Make WordPress Core

Opened 10 years ago

Last modified 3 years ago

#27139 new defect (bug)

Image caption disappears if images are rearranged immediately after adding the caption.

Reported by: cfinke's profile cfinke Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch needs-testing
Focuses: Cc:

Description

Steps to reproduce (screencast here: http://youtu.be/MF2SEn_lMeQ):

  1. While editing a post, open the Add Media dialog.
  2. Upload (or select) two images and choose "Create Gallery."
  3. Click "Create New Gallery".
  4. Add a caption to the first image in the text field underneath the image preview in the main "Edit Gallery" area.
  5. Drag the second image so that it is reordered in front of the first image.

What I expected:

The images would be reordered and the image captions would not be changed.

What actually happened:

The images were reordered, but the image caption I had just entered reverted to its previous state.

Clicking in any other text field before reordering images seems to "cement" the caption, but you can click on multiple images before dragging an image, and the caption will still revert.

Attachments (3)

27139.diff (510 bytes) - added by hereswhatidid 10 years ago.
Trigger blur on any inputs currently in focus when sorting is initiated.
27139.2.patch (531 bytes) - added by Fab1en 8 years ago.
Refreshing the patch. @hereswhatidid solution is still valid and work for trunk.
27139.3.patch (610 bytes) - added by cfinke 3 years ago.
Fixes the issue in version 5.6.1 by triggering the focused caption input's change event before a reorder happens.

Download all attachments as: .zip

Change History (12)

#1 @cfinke
10 years ago

Oh, browser details: The screencast and described behavior are in Firefox 27 on Mac OS X 10.9.1.

In Chrome 32 on Mac OS X 10.9.1, the behavior is a little different: If you drag and drop the image that you just added the caption to, the caption is not lost. However, if you drag and drop another image, even if it doesn't change the location of the captioned image, the caption is lost.

#2 follow-up: @nacin
10 years ago

I'd be curious to know if this is reproducible in 3.5, or if it regressed at some point since then.

#3 in reply to: ↑ 2 @cfinke
10 years ago

Replying to nacin:

I'd be curious to know if this is reproducible in 3.5, or if it regressed at some point since then.

Yes, confirmed just now that it is reproducible in 3.5 as well.

#4 @hereswhatidid
10 years ago

This appears to be happening because the collection reset event is being triggered prior to the caption:update event. Disabling the reset fixes the issue but it's documentation alludes to the reset being needed to ensure other collections sync.

Last edited 10 years ago by hereswhatidid (previous) (diff)

@hereswhatidid
10 years ago

Trigger blur on any inputs currently in focus when sorting is initiated.

#5 @SergeyBiryukov
10 years ago

  • Version changed from 3.8.1 to 3.5

#6 @chriscct7
8 years ago

  • Keywords needs-patch needs-testing added

@Fab1en
8 years ago

Refreshing the patch. @hereswhatidid solution is still valid and work for trunk.

#7 @Fab1en
8 years ago

  • Keywords has-patch added; needs-patch removed

#8 @cfinke
3 years ago

  • Keywords needs-testing has-patch removed

This bug is still present in 5.6.1 and is still very frustrating when encountered. The latest patch doesn't work, so I'll be trying to update it. I haven't worked on any of the media JS before, so it might be slow-going.

@cfinke
3 years ago

Fixes the issue in version 5.6.1 by triggering the focused caption input's change event before a reorder happens.

#9 @cfinke
3 years ago

  • Keywords has-patch needs-testing added

I've added a patch that is compatible with WordPress 5.6.1.

Note: See TracTickets for help on using tickets.